Bug 46474 - univention-add-app is deprecated and should not be used
univention-add-app is deprecated and should not be used
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center
UCS 5.0
Other All
: P5 normal (vote)
: UCS 5.0
Assigned To: Philipp Hahn
Dirk Wiesenthal
:
Depends on: 40064
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-02 20:45 CET by Dirk Wiesenthal
Modified: 2021-05-25 15:58 CEST (History)
6 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Cleanup
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2018-03-02 20:45:40 CET
Remove from test scripts
Remove from documentation
Remove from other scripts
... replace with univention-app

Change univention-add-app to resemble
  univention-app install --noninteractive --do-not-revert %(app)s
(And also add a note of deprecation)
Comment 1 Dirk Wiesenthal univentionstaff 2018-03-02 20:47:07 CET
univention-add-app should work in environments without insecure apt repositories. So most of the systems out there should actually be able to use it.
Comment 2 Dirk Wiesenthal univentionstaff 2018-03-02 20:49:57 CET
Change univention-add-app to resemble
  univention-app install --noninteractive --do-not-revert --do-not-install-master-packages-remotely %(app)s
Comment 3 Florian Best univentionstaff 2020-09-22 09:42:44 CEST
ucs-test (8.0.28-64)
4a0f117345c7 | Bug #46474: univention-add-app is deprecated
Comment 4 Philipp Hahn univentionstaff 2021-01-05 16:42:16 CET
univention-add-app is still referenced in
- doc/extended-docs/installation-5.0.xml
- services/univention-cloud-init/debian/univention-cloud-init.init (TBD with @edamrose if deprecated)
- test/ucs-test/tests/80_docker/dockertest.py (only disabled, code should be removed)

We should just remove it with 5.0-0 and document a replacement - IMHO no need to keep transitional code with the Major update.
Comment 5 Philipp Hahn univentionstaff 2021-01-06 13:26:23 CET
[5.0-0] 56a74b6c60 Bug #46474: Remove deprecated univention-add-app
 base/univention-updater/debian/changelog                        |   6 +
 base/univention-updater/debian/univention-updater.install       |   1 -
 base/univention-updater/script/univention-add-app               | 167 ----------------------------
 doc/changelog/changelog-5.0-0.xml                               |   3 +
 doc/extended-docs/installation-5.0.xml                          |   6 +-
 .../univention-cloud-init/debian/univention-cloud-init.init     |  16 ++-
 test/ucs-test/tests/80_docker/dockertest.py                     |  13 ---
 7 files changed, 22 insertions(+), 190 deletions(-)


QA FYI:
 Updater: Code removed - will be re-build later via Bug ##51316
 ucs-test was already disabled: code removed
 Update documentation: please QA
 Our cloud-init is known broken: just make is less broken
Comment 6 Dirk Wiesenthal univentionstaff 2021-01-26 15:54:57 CET
OK. Script removed, documentation updated. There may be small differences between a univention-add-app and a univention-app install

(as said in comment#2:
univention-app install --noninteractive --do-not-revert --do-not-install-master-packages-remotely
)

But the user gets the idea anyway.
Comment 7 Florian Best univentionstaff 2021-05-25 15:58:31 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".