Bug 46596 – [4.3] UCS@school wizards should offer object creation if non exist

Bug 46596 - [4.3] UCS@school wizards should offer object creation if non exist


Summary:	[4.3] UCS@school wizards should offer object creation if non exist

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	UMC - Wizards
Version:	UCS@school 4.3
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 4.3 v3
Assigned To:	Ole Schwiegert
QA Contact:	Jürn Brodersen

URL:
Keywords:

Depends on:
Blocks:	46826 46924
	Show dependency tree / graph

Reported:	2018-03-12 12:49 CET by Daniel Tröder
Modified:	2018-06-04 15:27 CEST (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	2: Improvement: Would be a product improvement
Who will be affected by this bug?:	1: Will affect a very few installed domains
How will those affected feel about the bug?:	3: A User would likely not purchase the product
User Pain:	0.034
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Usability
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Tröder

2018-03-12 12:49:58 CET

The user/workgroup/class/room/computer wizards should ask the user if he wishes to create a user/workgroup/class/room/computer if non exists.

This was once done, but the behavior changed at some point in UCS@school 4.2.

Comment 1 Sönke Schwardt-Krummrich

2018-03-12 13:12:54 CET

Please check, what the reason for this behaviour change was. We should then discuss, how the new behaviour should look like.

Comment 2 Ole Schwiegert

2018-03-20 10:55:13 CET

As far as I can tell the behavior is still implemented in the Grid baseclass of the schoolwizards (ucsschool/ucs-school-umc-wizards/umc/js/schoolwizards/Grid.js) in line 225ff. The dialog is hooked in via before aspect on the grids _onFetchComplete function.

After brief testing though I can tell that the aspect is never triggered and so the dialog never created. Is the _onFetchComplete function not called anymore?

Comment 3 Johannes Keiser

2018-03-20 12:08:28 CET

The implementation of the grid changed from the deprecated dojox/grid/EnhancedGrid
to dgrid: Bug #32027

Comment 4 Jürn Brodersen

2018-03-20 13:29:18 CET

onFilterDone might be a suitable alternative.

Comment 5 Ole Schwiegert

2018-03-22 11:24:43 CET

onFilterDone is indeed a suitable alternative. A fixing commit is available on the oschwieg/46596 branch.

Comment 6 Ole Schwiegert

2018-03-23 16:20:16 CET

Package: ucs-school-umc-wizards
Version: 10.0.1-1A~4.3.0.201803231614

Comment 7 Jürn Brodersen

2018-04-24 18:36:13 CEST

What I tested:

No users -> Creation wizard is shown -> OK
Users already exists -> No creation wizard is shown -> OK

[4.3 b7d90f21] Bug #46596: YAML

-> Verified

Note: workgroup and room are not part of the schoolwizards -> no creation wizard is shown -> Please open a new bug if that should be changed.

Comment 8 Sönke Schwardt-Krummrich

2018-05-02 17:59:04 CEST

UCS@school 4.3 v3 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.3v3-de.html

If this error occurs again, please clone this bug.