Bug 46872 - [Backport to 4.2] show dialog to create room instead of empty room selection
[Backport to 4.2] show dialog to create room instead of empty room selection
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Computer room
UCS@school 4.2
Other Linux
: P5 normal (vote)
: UCS@school 4.2 v10
Assigned To: Ole Schwiegert
Jürn Brodersen
:
Depends on: 43080
Blocks:
  Show dependency treegraph
 
Reported: 2018-04-23 14:09 CEST by Ole Schwiegert
Modified: 2018-07-04 18:07 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.034
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Usability
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ole Schwiegert univentionstaff 2018-04-23 14:09:11 CEST
+++ This bug was initially created as a clone of Bug #43080 +++

If there is no room yet and one opens the computeroom module one one need to select a room from an empty list. This is a first user experience. We should instead show a dialog which tells to create a room via the UMC module.
Comment 1 Ole Schwiegert univentionstaff 2018-04-23 14:09:36 CEST
Bug for backporting to 4.2
Comment 2 Ole Schwiegert univentionstaff 2018-04-24 09:42:51 CEST
Package: ucs-school-umc-computerroom
Version: 9.0.9-1A~4.2.0.201804240940
Comment 3 Daniel Tröder univentionstaff 2018-05-03 13:45:00 CEST
DC Master:

root@m120:~# python -c '
> import univention.admin.uldap
> from ucsschool.lib.models import ComputerRoom, School
> lo, po = univention.admin.uldap.getAdminConnection()
> for school in School.get_all(lo):
>     print school.name, ComputerRoom.get_all(lo, school.name)'
SchuleEins [ComputerRoom(name='SchuleEins-room01', school='SchuleEins', dn='cn=SchuleEins-room01,cn=raeume,cn=groups,ou=SchuleEins,dc=uni,dc=dtr'), ComputerRoom(name='SchuleEins-room02', school='SchuleEins', dn='cn=SchuleEins-room02,cn=raeume,cn=groups,ou=SchuleEins,dc=uni,dc=dtr'), ComputerRoom(name='SchuleEins-room03', school='SchuleEins', dn='cn=SchuleEins-room03,cn=raeume,cn=groups,ou=SchuleEins,dc=uni,dc=dtr')]
SchuleZwei []
SchuleDrei []
SchuleVier []

root@m120:~# python -c '
> import univention.admin.uldap
> from ucsschool.lib.models import ComputerRoom, School
> lo, po = univention.admin.uldap.getAdminConnection()
> for school in School.get_all(lo):
>     for room in ComputerRoom.get_all(lo, school.name):
>         room.remove(lo)'

root@m120:~# python -c '
import univention.admin.uldap
from ucsschool.lib.models import ComputerRoom, School
lo, po = univention.admin.uldap.getAdminConnection()
for school in School.get_all(lo):
    print school.name, ComputerRoom.get_all(lo, school.name)'
SchuleEins []
SchuleZwei []
SchuleDrei []
SchuleVier []

DC Slave:

root@s121:~# dpkg -l ucs-school-umc-computerroom
ii  ucs-school-umc-computerr 9.0.9-1A~4.2.0.20 all

In the UMC, the module opens and displays the empty list for the (aphabetically sorted) first OU. No dialog appears. Logged in as "Administrator".
Comment 4 Daniel Tröder univentionstaff 2018-05-03 13:47:30 CEST
Tested with Chrome 66.0.3359.139 (stable) and Firefox ESR 52.7.3.
Comment 5 Ole Schwiegert univentionstaff 2018-05-08 08:18:09 CEST
This bug is concerned with the Education->computerroom module and not the school administration->room management module.
Comment 6 Ole Schwiegert univentionstaff 2018-05-30 09:56:26 CEST
src: ucs-school-umc-rooms
fix: 14.0.1-1A~4.2.0.201805300953

src: ucs-school-umc-computerroom
fix: 9.0.9-2A~4.2.0.201805300955
Comment 7 Jürn Brodersen univentionstaff 2018-06-05 17:21:25 CEST
See bug 43080 comment 12
Comment 8 Ole Schwiegert univentionstaff 2018-06-07 08:57:44 CEST
Same fixes as mentioned in Bug #43080

src: ucs-school-umc-computerroom
fix: 9.0.9-3A~4.2.0.201806070855

src: ucs-school-umc-rooms
fix: 14.0.1-2A~4.2.0.201806070853
Comment 9 Jürn Brodersen univentionstaff 2018-06-08 17:46:57 CEST
OK
looks good now :)

-> Verified
Comment 10 Sönke Schwardt-Krummrich univentionstaff 2018-07-04 18:07:45 CEST
UCS@school 4.2 v10 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.2v10-de.html

If this error occurs again, please clone this bug.