Bug 46889 – The exit code of univention-domain-join-cli should not be 0 on errors

Bug 46889 - The exit code of univention-domain-join-cli should not be 0 on errors


Summary:	The exit code of univention-domain-join-cli should not be 0 on errors

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Univention Domain Join (Ubuntu)
Version:	UCS 4.3
Hardware:	Other Linux

Importance:	P5 enhancement (vote)
Target Milestone:	UCS 4.3-0-errata
Assigned To:	Richard Ulmer
QA Contact:	Arvid Requate

URL:	https://github.com/univention/univent...
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-04-26 09:41 CEST by Richard Ulmer
Modified:	2018-09-18 07:46 CEST (History)
CC List:	4 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	2: Improvement: Would be a product improvement
Who will be affected by this bug?:	1: Will affect a very few installed domains
How will those affected feel about the bug?:	1: Nuisance – not a big deal but noticeable
User Pain:	0.011
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	External feedback
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Richard Ulmer

2018-04-26 09:41:51 CEST

A customer reported in the forum, that the tool does exit with exit code 0 on an error: https://help.univention.com/t/univention-domain-join-cli-fur-ubuntu-problem/8527/6

This should be changed.

Comment 1 Richard Ulmer

2018-04-26 10:24:04 CEST

univention-domain-join-cli will now return exit code 1 on errors.

ubunut18.04
0aeaf4d90c49 | Bug #46889: Add changelog entry
1d4de47eca39 | Bug #46889: Exit with exit code 1 on errors

ubuntu17.10
6ab22306e4a3 | Bug #46889: Exit with exit code 1 on errors
85addfc4c039 | Bug #46889: Add changelog entry

ubuntu16.04
69c28094c338 | Bug #46889: Exit with exit code 1 on errors
30e884fd39e3 | Bug #46889: Add changelog entry

ubuntu14.04
0dfa67262f42 | Bug #46889: Add changelog entry
e3935398809f | Bug #46889: Exit with exit code 1 on errors

Comment 2 Arvid Requate

2018-07-12 19:38:16 CEST

Ok

Comment 3 Stefan Gohmann

2018-09-18 07:46:22 CEST

OK, this bug can be closed.