Bug 47160 - Collecting files will not work without prior distribution of files
Summary: Collecting files will not work without prior distribution of files
Status: CLOSED FIXED
Alias: None
Product: UCS@school
Classification: Unclassified
Component: UMC - Exam mode
Version: UCS@school 4.3
Hardware: All All
: P5 normal
Target Milestone: UCS@school 4.4 v3
Assignee: Jürn Brodersen
QA Contact: Ole Schwiegert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-08 09:42 CEST by frowedder
Modified: 2019-05-08 22:26 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Usability
Customer ID:
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description frowedder 2018-06-08 09:42:22 CEST
During exam mode, pupils' files will not be collected when there was no prior distribution of files by the teacher, resulting in probable loss of files.

The obvious reason for this is that files will only be collected from the directory "\Klassenarbeiten\[Name der Arbeit]\". However, this directory will not be created if no files are distributed, so the collection of material will return no results. 
The user (teacher) will not even get an error message, so after ending exam mode, the pupils' files will be lost.
Comment 1 Jürn Brodersen univentionstaff 2019-04-23 15:29:16 CEST
[4.4 442cc5652] Bug #47160: Allow distribution of empty projects
[4.4 7b2433220] Bug #47160: Add tests for distributing empty projects
[4.4 dece2b341] Bug #47160: Merge branch 'juern/bug47160_distribute_empty_projects' into 4.4
[4.4 ea7a3b9ed] Bug #47160: yaml

Package: ucs-school-umc-distribution
Version: 17.0.0-2A~4.4.0.201904231520
Branch: ucs_4.4-0
Scope: ucs-school-4.4

Note for qa:
The distribution status of a project is now stored in its metadata. Please add two projects, one distributed one not, prior to updating to check for backwards compatibility.

Relevant tests:
18_distribute_empty_materials_check
101_exam_mode_empty_distribution
Comment 2 Jürn Brodersen univentionstaff 2019-04-23 16:01:05 CEST
(In reply to Jürn Brodersen from comment #1)

> Note for qa:
> The distribution status of a project is now stored in its metadata. Please
> add two projects, one distributed one not, prior to updating to check for
> backwards compatibility.


Should have tested that myself better... sorry
[4.4 01a718fa7] Bug #47160: fix distribution status for old projects
[4.4 402ca834f] Bug #47160: yaml
Package: ucs-school-umc-distribution
Version: 17.0.0-3A~4.4.0.201904231558
Branch: ucs_4.4-0
Scope: ucs-school-4.4
Comment 3 Ole Schwiegert univentionstaff 2019-05-06 09:19:23 CEST
Advisory&Changelog: OK
Package installs: OK
Test passes: OK
Collect newly created empty project: OK
Collect preupdate created empty project: OK
Project collection works as expected

I have one issue with the user experience. As it should be the user is warned when he wants to distribute an empty project and is asked for confirmation. After that he is asked again to confirm the distribution of the project (which is the dialog already existing prior to this update).

One confirmation should suffice to distribute a project. Maybe using only one of the two dialogs and changing the text depending on the status could be a solution.
Comment 4 Jürn Brodersen univentionstaff 2019-05-06 12:25:48 CEST
[4.4 f408a1db4] Bug #47160: Remove separate confirmation dialog for empty projects
[4.4 4d093a7b0] Bug #47160: yaml
Comment 5 Ole Schwiegert univentionstaff 2019-05-07 08:31:53 CEST
Advisory&Changelog: OK
Package installs: OK
Behavior as expected: OK
Only one dialog: OK, thanks this improves the UX greatly
Comment 6 Sönke Schwardt-Krummrich univentionstaff 2019-05-08 22:26:32 CEST
UCS@school 4.4 v2 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.4v2-de.html

If this error occurs again, please clone this bug.