Bug 47162 - New exception that is not considered when checking tolerate_errors
New exception that is not considered when checking tolerate_errors
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: Import scripts
UCS@school 4.3
Other Linux
: P5 normal (vote)
: UCS@school 4.3 v5
Assigned To: Sönke Schwardt-Krummrich
Daniel Tröder
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-06-08 17:23 CEST by Sönke Schwardt-Krummrich
Modified: 2018-09-11 11:34 CEST (History)
0 users

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sönke Schwardt-Krummrich univentionstaff 2018-06-08 17:23:34 CEST
A new exception is required that can be thrown if an import record is to be intentionally skipped. However, the exception should not be included in the count of tolerate_errors, so that the import can still be terminated after X real errors.
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2018-07-12 14:50:24 CEST
The new exception UcsSchoolImportSkipImportRecord has been introduced that uses the new boolean member variable is_countable.

_add_error() now only raises a TooManyErrors exception, if the number of countable exception exceeds the limit.

ucs-school-import (16.0.2-24)
908aaecb5fd0 | Bug #47162: add new exception type UcsSchoolImportSkipImportRecord
Comment 2 Daniel Tröder univentionstaff 2018-07-27 16:25:47 CEST
OK: code

I added a ucs-test to test this feature:

[4.3] 1b24b91c1 Bug #47162: add test for not is_countable exception

ucs-test-ucsschool (5.0.2-72)
Comment 3 Sönke Schwardt-Krummrich univentionstaff 2018-09-11 11:34:20 CEST
UCS@school 4.3 v5 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.3v5-de.html

If this error occurs again, please clone this bug.