Bug 47205 - Remove deprecated univention.lib.umc_connection
Remove deprecated univention.lib.umc_connection
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: univention-lib
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.4-2-errata
Assigned To: Philipp Hahn
Florian Best
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-06-19 13:54 CEST by Philipp Hahn
Modified: 2019-10-16 14:11 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
hahn: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2018-06-19 13:54:37 CEST
base/univention-lib/python/umc_connection.py:   'univention.lib.umc_connection is deprecated, use univention.lib.umc instead!\n'

The module is marked as deprecated since UCS-4.2?

test/ucs-test/tests/20_appcenter/60_check_appcenter_performance:        print("Getting umc_connection")
test/utils/schoolinstaller41.py:        from univention.lib.umc_connection import UMCConnection

That is the last in-tree user which can be easily fixed.
Comment 2 Florian Best univentionstaff 2019-10-10 12:20:39 CEST
(In reply to Philipp Hahn from comment #1)
> This removes the last in-code usage:
> <https://git.knut.univention.de/univention/ucs/commit/
> 6a74a81f262565a3e5af310d0f261f33c98b7f6e>

You also have to change the socket.error into univention.lib.umc.ConnectionError!
If you want you can fix it today.
Comment 3 Philipp Hahn univentionstaff 2019-10-10 14:26:41 CEST
[4.4-2] b6d4f3b7d0 Bug #47205: Remove deprecated univention.lib.umc_connection
 base/univention-lib/debian/changelog               |   6 +
 base/univention-lib/debian/control                 |   2 +-
 base/univention-lib/python/umc_connection.py       | 169 --------------------
 .../20_appcenter/60_check_appcenter_performance    |   2 +-
 test/utils/schoolinstaller41.py                    | 172 ---------------------
 5 files changed, 8 insertions(+), 343 deletions(-)

Package: univention-lib
Version: 8.0.1-28A~4.4.0.201910101412
Branch: ucs_4.4-0
Scope: errata4.4-2

[4.4-2] 3939dec2ba Bug #47205: univention-lib 8.0.1-28A~4.4.0.201910101412
 doc/errata/staging/univention-lib.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)
Comment 4 Florian Best univentionstaff 2019-10-10 17:16:49 CEST
Aaand, it's gone…

OK: Removal: The schoolinstaller41.py was for the Jenkins jobs starting at UCS 4.1/4.2 upgrading to UCS 4.2/4.3.
Comment 5 Arvid Requate univentionstaff 2019-10-16 14:11:03 CEST
<http://errata.software-univention.de/ucs/4.4/307.html>