Bug 47367 – univention-samba postinst doesn't restart samba / Broken /etc/init.d/samba call (crestart)

Bug 47367 - univention-samba postinst doesn't restart samba / Broken /etc/init.d/samba call (crestart)


Summary:	univention-samba postinst doesn't restart samba / Broken /etc/init.d/samba ca...

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Samba
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0
Assigned To:	Arvid Requate
QA Contact:	Florian Best

URL:
Keywords:

Depends on:	45326
Blocks:
	Show dependency tree / graph

Reported:	2018-07-17 18:51 CEST by Hendrik Peter
Modified:	2021-05-25 15:59 CEST (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Hendrik Peter

2018-07-17 18:51:38 CEST

Package: univention-samba
File: debian/univention-samba.postinst
Line: 169
Noticed in Version: 12.0.1-5A~4.3.0.201806201013

This looks like it has been broken for quite some time. Line 169 of the 'univention-samba' postinst tries to restart the samba-service with following command:
 /etc/init.d/samba crestart

Samba's init script doesn't understand 'crestart' and just outputs the usage post:
 "Usage: /etc/init.d/samba {start|stop|reload|restart|force-reload|status}"

This might not break anything but doesn't look nice in the upgrade log.

Comment 1 Arvid Requate

2018-07-23 11:24:16 CEST

Define: "Quite some time" := UCS 4.3-0 commit c52bff3f85

Comment 2 Ingo Steuwer

2019-08-30 09:37:04 CEST

I assume this should be fixed in UCS 4.4 (with the fix to restart samba in den UMC services module)?

Comment 3 Florian Best

2019-08-30 09:40:20 CEST

(In reply to Ingo Steuwer from comment #2)
> I assume this should be fixed in UCS 4.4 (with the fix to restart samba in
> den UMC services module)?
No.

Comment 4 Arvid Requate

2020-11-11 20:12:35 CET

6b99967fc0 | Fix samba crestart
fbfcdbe70d | UCS 5 changelog

Package: univention-samba
Version: 14.0.1-4A~5.0.0.202011112010
Branch: ucs_5.0-0

Comment 5 Florian Best

2020-12-08 15:34:03 CET

OK: restart
OK: changelog entry

Comment 6 Florian Best

2021-05-25 15:59:04 CEST

UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".