Bug 47381 – notifier stopped during import dry-run

Bug 47381 - notifier stopped during import dry-run


Summary:	notifier stopped during import dry-run

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	Import scripts
Version:	UCS@school 4.3
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 4.4 v4
Assigned To:	Daniel Tröder
QA Contact:	Jürn Brodersen

URL:
Keywords:

Depends on:	47203
Blocks:
	Show dependency tree / graph

Reported:	2018-07-19 12:27 CEST by Jürn Brodersen
Modified:	2019-08-05 18:42 CEST (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.069
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jürn Brodersen

2018-07-19 12:27:44 CEST

notifier stopped during import dry-run

At least for me that isn't the behavior I expect from a dry-run. The notifier should not be stopped since it should not be necessary to stop it during a dry-run.

Comment 1 Daniel Tröder

2018-07-23 14:42:48 CEST

ACK.

Adding dependency on Bug #47203, so we can be sure a dry-run commits no changes to LDAP.
(The read-only cn=admin connection is *much* faster than the unprivileged connection provided by get_unprivileged_connection(), as it bypasses all ACLs.)

Comment 2 Daniel Tröder

2019-03-18 09:17:29 CET

In a dry-run, the notifier won't be stopped anymore.

[dtroeder/47381_no.notifier.stop.in.dry.run 396f65378] Bug #47381: don't stop notifier in import dry-run

Please reopen, if you want to QA this and it should be merged, built and an advisory written.

Comment 3 Daniel Tröder

2019-07-29 14:29:54 CEST

[4.4] 7c6e5bb51 Bug #47381: don't stop notifier in import dry-run
[4.4] 2d2a18089 Bug #47381: Merge branch 'dtroeder/47381_no.notifier.stop.in.dry.run' into 4.4
[4.4] 5ce5a78db Bug #47381: changelog
[4.4] 8702a3da6 Bug #47381: advisory

ucs-school-import (17.0.6-23)

Comment 4 Jürn Brodersen

2019-07-31 18:23:11 CEST

[4.4 866df0f9e] Bug #47381: rename noop -> nullcontext
[4.4 fe12e2a01] Bug #47381: yaml

What I tested:
ucs-school-user-import dry-run -> notifier is not stopped -> OK
ucs-school-user-import -> notifier is stopped -> OK
34_import-users-legacy -> OK
34_import-users_via_python_api -> OK
235_import-users_dry-run-support_in_pyhooks

-> Verified

Comment 5 Daniel Tröder

2019-08-05 18:42:01 CEST

UCS@school 4.4 v3 has been released.

https://docs.software-univention.de/release-notes-ucsschool-4.4v3-de.html

If this error occurs again, please clone this bug.