Bug 47393 - Not possible to delete multiple workgroups
Not possible to delete multiple workgroups
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Wizards
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v9-errata
Assigned To: Ole Schwiegert
Tobias Wenzel
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-07-24 17:02 CEST by Jürn Brodersen
Modified: 2021-04-21 10:44 CEST (History)
7 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?: 5: Will affect all installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.229
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jürn Brodersen univentionstaff 2018-07-24 17:02:25 CEST
Not possible to delete multiple workgroups

This is deactivated in the frontend and the backend does not support this at the moment.

I would suggest to also move the code into the school wizard package for easier maintainability.
Comment 1 Lukas Zumvorde univentionstaff 2019-09-23 16:46:54 CEST
I have another customer that wishes to have this feature. I is not logical from a users point of view and interrupts the workflow
Comment 2 Michel Smidt 2019-09-23 16:51:11 CEST
(In reply to Lukas Zumvorde from comment #1)
> I have another customer that wishes to have this feature. I is not logical
> from a users point of view and interrupts the workflow

Can you add the Customer ID?
Comment 3 Lukas Zumvorde univentionstaff 2019-09-23 17:03:59 CEST
Correction. It is the same customer that has raised this issue again.
Comment 4 Ole Schwiegert univentionstaff 2021-03-25 13:31:58 CET
Implemented deletion of multiple work groups:

Package: ucs-school-umc-groups
Version: 9.0.0-10A~4.4.0.202103251328
Branch: ucs_4.4-0
Scope: ucs-school-4.4

To keep this Bug short, the code was not migrated but kept in its own package. If the merge is still desired, please open a new Bug.

-- Multiple WorkingGroups can now be deleted via UMC
-- Documentation did not need to be adapted
-- Please test for singleserver/multiserver and check jenkins
Comment 5 Tobias Wenzel univentionstaff 2021-03-25 16:20:38 CET
QA → REOPEN because of traceback in multi-server env

Code:

if len(errors) > 0:

I would prefer `if errors` but this is also OK/correct :)

before: no multi-delete possible
after: multi-delete possible

Single-Server Env → OK
Multi-Server Env → Please check


When I tried this on a replication node, only one of three classes appeared to be deleted (in the umc). When clicking again on delete I got the following traceback, because the groups had of course already been deleted.
I could reproduce this multiple times.


  File "/usr/lib/pymodules/python2.7/univention/management/console/modules/schoolgroups/__init__.py", line 383, in remove
    group = WorkGroup.from_dn(group_dn, None, ldap_user_write)
  File "/usr/lib/pymodules/python2.7/ucsschool/lib/models/base.py", line 1055, in from_dn
    superordinate=superordinate,
  File "/usr/lib/python2.7/dist-packages/univention/admin/modules.py", line 913, in lookup
    tmpres = module.lookup(co, lo, filter, base=base, superordinate=superordinate, scope=scope, unique=unique, required=required, timeout=timeout, sizelimit=sizelimit)
  File "/usr/lib/python2.7/dist-packages/univention/admin/handlers/__init__.py", line 1741, in lookup
    for dn, attrs in lo.search(filter_str, base, scope, attr, unique, required, timeout, sizelimit, serverctrls=serverctrls, response=response):
  File "/usr/lib/python2.7/dist-packages/univention/admin/uldap.py", line 757, in search
    raise univention.admin.uexceptions.noObject(_err2str(msg))
noObject: No such object
Comment 6 Toni Röhmeyer univentionstaff 2021-04-12 13:08:15 CEST
Issue from comment #5 fixed on branch troehmey/bug47393_delete_multiple_workgroups:

303849401 Bug #47393: added test deleting multiple workgroups
2dceb5d12 Bug #47393: fix workgroup query
Comment 7 Tobias Wenzel univentionstaff 2021-04-14 12:53:46 CEST
QA 
As discussed

- change the comments, save the commented out test as a 
patch - we might need it, but not in this file
- merge & build in 4.4
Comment 8 Toni Röhmeyer univentionstaff 2021-04-14 14:28:45 CEST
I added the fixup suggested in comment #7 and merged to 4.4 with

4ae6db3ac Bug #47393: updated yaml version
9892292ac Bug #47393: added changelog entries
0e60fce1e Bug #47393: Merge branch 'troehmey/bug47393_delete_multiple_workgroups' into 4.4
7b442224c Bug #47393: added test deleting multiple workgroups

Builds:
Package: ucs-school-umc-groups
Version: 9.0.0-11A~4.4.0.202104141418
Branch: ucs_4.4-0
Scope: ucs-school-4.4

Package: ucs-test-ucsschool
Version: 6.0.203A~4.4.0.202104141424
Branch: ucs_4.4-0
Scope: ucs-school-4.4
Comment 9 Tobias Wenzel univentionstaff 2021-04-14 14:44:25 CEST
QA 

merge → OK
changelog → OK
yaml version → OK

waiting for Jenkins to verify
Comment 10 Tobias Wenzel univentionstaff 2021-04-15 09:18:53 CEST
The tag "apptest" was missing. I already commited/ build the changes.

E: De-selected by tag: apptest

Package: ucs-test-ucsschool
Version: 6.0.204A~4.4.0.202104150917
Branch: ucs_4.4-0
Scope: ucs-school-4.4
Comment 11 Tobias Wenzel univentionstaff 2021-04-16 08:27:31 CEST
Wonderful: the tests are now executed in our mult-server envs tests (jenkins) and pass.

→ verify
Comment 12 Daniel Tröder univentionstaff 2021-04-21 10:44:45 CEST
Released as erratum for UCS@school 4.4 v9.

If you wish to reopen this bug, please clone it instead.