Bug 47413 – ucs-school-import: cleanup unreachable code

Bug 47413 - ucs-school-import: cleanup unreachable code


Summary:	ucs-school-import: cleanup unreachable code

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	Import scripts
Version:	UCS@school 4.1 R2
Hardware:	Other Linux

Importance:	P5 enhancement (vote)
Target Milestone:	UCS@school 4.3 v5
Assigned To:	Daniel Tröder
QA Contact:	Jürn Brodersen

URL:
Keywords:

Depends on:	41882
Blocks:
	Show dependency tree / graph

Reported:	2018-07-30 14:20 CEST by Daniel Tröder
Modified:	2018-09-11 11:34 CEST (History)
CC List:	0 users

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	2: Improvement: Would be a product improvement
Who will be affected by this bug?:	4: Will affect most installed domains
How will those affected feel about the bug?:	3: A User would likely not purchase the product
User Pain:	0.137
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Tröder

2018-07-30 14:20:51 CEST

To lower the memory footprint of an import, "users to delete" were changed from a list of ImportUser objects to a list of tuples in Bug #41882.
There is leftover, unreachable code to remove.

Comment 1 Daniel Tröder

2018-07-30 14:23:57 CEST

[4.3] b24d3b693 Bug #47413: cleanup: remove unreachable code
[4.3] 834c08e7b Bug #47413: advisory

Comment 2 Daniel Tröder

2018-07-30 14:35:57 CEST

[4.3] cb4394e9e Bug #47413: remove unnecessary dict
[4.3] 696805e39 Bug #47413: advisory

Comment 3 Jürn Brodersen

2018-08-07 12:12:38 CEST

OK

What I tested:
Imported users -> OK
Imported new set of users for the same sourceUID -> old users are deleted -> OK

YAML -> OK

Comment 4 Sönke Schwardt-Krummrich

2018-09-11 11:34:18 CEST

UCS@school 4.3 v5 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.3v5-de.html

If this error occurs again, please clone this bug.