Bug 47424 – ldap.sh uses "die" but "die" is not defined in univention-lib

Bug 47424 - ldap.sh uses "die" but "die" is not defined in univention-lib


Summary:	ldap.sh uses "die" but "die" is not defined in univention-lib

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	univention-lib
Version:	UCS 4.3
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.3-3-errata
Assigned To:	Julia Bremer
QA Contact:	Erik Damrose

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-07-31 13:11 CEST by Sönke Schwardt-Krummrich
Modified:	2019-02-13 13:27 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.069
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sönke Schwardt-Krummrich

2018-07-31 13:11:08 CEST

ldap.sh uses the shell function die() in ucs_parseCredentials(), but "die" is not defined anywhere in univention-lib.

Comment 1 Erik Damrose

2018-07-31 13:13:23 CEST

It is defined in management/univention-join/joinscripthelper.lib

Comment 2 Arvid Requate

2019-02-11 21:59:34 CET

Ok the commit bfba478a2d now defines die() in univention-lib/shell/ldap.sh, two things are missing:

* The 'echo "$1"' should probably be a 'echo "$@"' to match the implementation of 
management/univention-join/joinscripthelper.lib, quoted by Erik.

* We need a yaml advisory. Strictly speaking we need it before changing any code.


Please fix this ASAP, because it's blocking the release of the fix for Bug #48427 which is of top priority currently.

Comment 3 Julia Bremer

2019-02-12 08:55:11 CET

321ad813de Bug #47424: Advisory
7e40dff954 Bug #47424: Fix typo and changelog
4d7b6a6708 Bug #47424: Changelog
87684513d4 Bug #47424 Merge branch 'jbremer/bug47424' into 4.3-3
bfba478a2d Bug #47424: defined method die in ldap.sh

Successful build
Package: univention-lib
Version: 7.0.0-23A~4.3.0.201902120851
Branch: ucs_4.3-0
Scope: errata4.3-3
User: jbremer

Comment 4 Erik Damrose

2019-02-12 10:48:35 CET

OK: univention-lib specific die() implementation
OK: fix merged and built in 4.3-3, merged and built in 4.4-0
OK: yaml
Verified

Comment 5 Erik Damrose

2019-02-13 13:27:23 CET

<http://errata.software-univention.de/ucs/4.3/424.html>