Bug 47436 - Updating a patchlevel during system-setup will abort system-setup when an erratum restarts UMC
Updating a patchlevel during system-setup will abort system-setup when an err...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: System setup
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3-1-errata
Assigned To: Erik Damrose
Felix Botner
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-08-01 17:25 CEST by Erik Damrose
Modified: 2019-03-15 22:52 CET (History)
5 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 6: Setup Problem: Issue for the setup process
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.514
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Workaround is available
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Damrose univentionstaff 2018-08-01 17:25:21 CEST
During system setup we disable the restart of UMC, because umc-server starts setup-join.sh in a subprocess.

When the checkbox to install updates during system setup is checked, we install all available patchlevel updates. But in univention-updater postup.sh we explicitely enable UMC restart again with /usr/share/univention-updater/enable-apache2-umc.

This will cause system-setup to abort when an erratum in the next patchlevel exists that restarts UMC-server. System-setup hook and cleanup scripts will not be called, so the system is in an undefined state.

The bug is also relevant for App Appliances which are not the latest patchlevel. Our UCS Appliances are usually on the latest patchlevel.

To reproduce, one can install from UCS 4.3-0 and update to 4.3-1 during system setup.

A real fix would be to make setup-join.sh not a child process of umc-server, but start it independently.

Workaround is to uncheck the 'update system' option in system setup.
Comment 1 Stefan Gohmann univentionstaff 2018-08-02 07:50:09 CEST
(In reply to Erik Damrose from comment #0)
> When the checkbox to install updates during system setup is checked, we
> install all available patchlevel updates. But in univention-updater
> postup.sh we explicitely enable UMC restart again with
> /usr/share/univention-updater/enable-apache2-umc.

Maybe we can simply check in postup.sh if the update has been started through system setup?
Comment 2 Erik Damrose univentionstaff 2018-08-02 10:43:32 CEST
e3bc45ad univention-updater 
No package rebuild, as it is just a postup change.

In postup.sh, do not reenable apache2 and UMC restarts,
when system-setup is running. System-setup will reenable it at the
end of the setup.

I copied the signed postup.sh to the testing and test_mirror. In a test install with 4.3-0, the update to 4.3-1 was done, and system setup completed successfully.
Comment 3 Felix Botner univentionstaff 2018-08-02 12:13:54 CEST
!
Comment 4 Erik Damrose univentionstaff 2018-08-02 12:23:47 CEST
I fixed the logic error in 78c8ff962 and updated the file on both test mirrors
Comment 5 Felix Botner univentionstaff 2018-08-02 16:44:50 CEST
OK, release
Comment 6 Erik Damrose univentionstaff 2018-08-02 17:29:57 CEST
published on external mirror
Comment 7 Felix Botner univentionstaff 2018-08-03 16:27:54 CEST
OK