Bug 47451 - ucsschoolRole is set when creating users even if ucsschoolRole is deactivated
Summary: ucsschoolRole is set when creating users even if ucsschoolRole is deactivated
Status: CLOSED FIXED
Alias: None
Product: UCS@school
Classification: Unclassified
Component: Import scripts
Version: UCS@school 4.3
Hardware: Other Linux
: P5 normal
Target Milestone: UCS@school 4.3 v5
Assignee: Daniel Tröder
QA Contact: Jürn Brodersen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-03 14:31 CEST by Sönke Schwardt-Krummrich
Modified: 2018-09-11 11:34 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 5: Will affect all installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.171
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Customer ID: 00009
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sönke Schwardt-Krummrich univentionstaff 2018-08-03 14:31:58 CEST 
ucsschoolRole is set when creating users even if ucsschoolRole is deactivated. If the user is modified, the ucsschoolRole is not updated:

dn: uid=v.schulz,cn=lehrer,cn=users,ou=222,dc=nstx,dc=local
ucsschoolRole: teacher:school:001
Comment 1 Daniel Tröder univentionstaff 2018-08-06 11:41:35 CEST 
[4.3] 4fa862134 Bug #47451: don't fill ucsschool_role attribute if feature is deactivated
[4.3] 610d5edf7 Bug #47451: test if ucsschool_role attribute is unset when feature is deactivated
[4.3] 71f6e2050 Bug #47451: test attribute is empty if property is unset
[4.3] 564fae3b4 Bug #47451: cache UCR access
[4.3] f6b276cc8 Bug #47451: advisory

ucs-school-import (16.0.2-34)
ucs-test-ucsschool (5.0.2-79)
Comment 2 Daniel Tröder univentionstaff 2018-08-13 16:32:57 CEST 
[4.3] 19070a259 Bug #47451: adapt tests to changed expected_attributes()

ucs-test-ucsschool (5.0.2-80)
Comment 3 Jürn Brodersen univentionstaff 2018-09-04 10:17:22 CEST 
What I tested:

ucsschoolRole is not set by the importer when deactivated anymore -> OK
ucsschoolRole is set by the importer when activated -> OK

YAML -> OK

-> Verified
Comment 4 Sönke Schwardt-Krummrich univentionstaff 2018-09-11 11:34:16 CEST 
UCS@school 4.3 v5 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.3v5-de.html

If this error occurs again, please clone this bug.