Bug 47467 – [4.3] Password with "$" breaks creation of Extended Attributes

Bug 47467 - [4.3] Password with "$" breaks creation of Extended Attributes


Summary:	[4.3] Password with "$" breaks creation of Extended Attributes

Status:	CLOSED FIXED

Product:	Z_Internal OX development
Classification:	Unclassified
Component:	Installer
Version:	UCS 4.3 / 7.10.0
Hardware:	Other other

Importance:	P5 normal (vote)
Target Milestone:	7.10.0-ucs2
Assigned To:	Daniel Tröder
QA Contact:	Erik Damrose

URL:
Keywords:

Depends on:	47457
Blocks:
	Show dependency tree / graph

Reported:	2018-08-07 14:07 CEST by Daniel Tröder
Modified:	2018-11-15 11:20 CET (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	6: Setup Problem: Issue for the setup process
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	4: A User would return the product
User Pain:	0.274
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Tröder

2018-08-07 14:07:07 CEST

+++ This bug was initially created as a clone of Bug #47457 +++

With a password like "Pa$2018" the following command in the joinscript will fail:

https://git.knut.univention.de/univention/open-xchange/appsuite/blob/4.2/univention-ox/65univention-ox.inst#L172

"createextattr.py" prints some udm commands that are supposed to create OX Extended Attributes. But with a password like "Pa$2018", only "Pa018" is printed as bindpwd. The udm commands will then fail, but the joinscript does NOT. This leads to a "successfully" installed OX App, but all the Extended Attributes for users/user are missing.

Comment 1 Daniel Tröder

2018-08-08 13:05:48 CEST

[4.3] e4c2658 Bug #47467: create extended attributes directly in script and with Python
[4.3] eb31e36 Bug #47467: quote all columns (csv.QUOTE_ALL)
[4.3] 25f0c95 Bug #47467: changelog
[4.3] 274f1d8 Bug #47467: advisory

univention-ox (10.0.0-24)

Comment 2 Daniel Tröder

2018-08-16 14:19:03 CEST

Commits have been reverted, packages built and uploaded to the test app center.

[4.3] 44b8bb4 Revert "Bug #47467: quote all columns (csv.QUOTE_ALL)"
[4.3] 59a827a Revert "Bug #47467: create extended attributes directly in script and with Python"
[4.3] 791fff0 Bug #47467: revert create extended attributes directly in script and with Python (10.0.0-24)
[4.3] 85ac096 Bug #47467: advisory update

univention-ox (10.0.0-29)

Comment 3 Erik Damrose

2018-08-17 16:42:32 CEST

OK: Revert in current test app

Comment 4 Daniel Tröder

2018-08-24 17:49:34 CEST

The extended attributes are now created using subprocess.call().

[4.3] 28ee210 Bug #47467: create extended attributes without shell pipe
[4.3] 94f2bd4 Bug #47467: changelog
[4.3] 7e8ce17 Bug #47467: advisory

Comment 5 Erik Damrose

2018-08-29 12:20:38 CEST

OK: Creation of attributes works with $ in password
OK: Identical extended attributes are created, compared to previous package version
OK: univention-ox (10.0.0-31)
-> Verified

Comment 6 Sönke Schwardt-Krummrich

2018-11-15 11:20:16 CET

Published yesterday with OX 7.10.0-ucs2