Bug 47646 - Reset password module - add password visibility toggle
Reset password module - add password visibility toggle
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Password reset
UCS@school 4.3
Other other
: P5 normal (vote)
: UCS@school 4.4 v2
Assigned To: Johannes Keiser
Ole Schwiegert
:
Depends on: 49099
Blocks: 50846
  Show dependency treegraph
 
Reported: 2018-08-23 19:43 CEST by Michael Grandjean
Modified: 2020-02-20 15:23 CET (History)
5 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): External feedback
Max CVSS v3 score:


Attachments
Patch/Change from TextBox to PasswordInputBox (1.16 KB, patch)
2019-02-21 09:09 CET, Hendrik Peter
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Grandjean univentionstaff 2018-08-23 19:43:23 CEST
This is based on customer feedback:

Currently, if a teacher/school-admin uses the "Passwords (students/teachers)" module, the password is shown in clear text and readable for everyone looking at the screen.

Suggested improvement: Mask the entered password (********), but also add an option to toggle between visible and masked. Android/iOS-Frameworks usually use an eye icon for this.
Comment 1 Jürn Brodersen univentionstaff 2018-08-27 12:40:53 CEST
We discussed that it would be best to use the existing password widget and modify that widget to include a visibility toggle.

Something similar is requested for ucs as well: bug 46888 and bug 45930
Comment 2 Hendrik Peter univentionstaff 2019-02-21 09:06:59 CET
Reported by a Teacher of an Enterprise Customer. 

This is a daily problem for Admins, when passwords of Students (or Teachers) need to be changed. This problem enlarges every year, when new classes begin their courses with new accounts and need to set their user account password through this module once.

A three-line patch has been attached.
Comment 3 Hendrik Peter univentionstaff 2019-02-21 09:09:13 CET
Created attachment 9851 [details]
Patch/Change from TextBox to PasswordInputBox
Comment 4 Sönke Schwardt-Krummrich univentionstaff 2019-02-24 01:18:32 CET
(In reply to Hendrik Peter from comment #2)
> A three-line patch has been attached.

JFYI: the patch permanently changes the text input into a password input

I would prefer bug 48666 as a permanent solution (together with your 3 lines :-).
Comment 5 Johannes Keiser univentionstaff 2019-03-21 17:30:23 CET
UCS:

77d90b590a Bug #47646: YAML
2e5439006c Bug #47646: Merge branch 'jkeiser/4.4-0/passwordbox' into 4.4-0
51cb410d10 Bug #47646: YAML
83d6638115 Bug #47646: debian changelog
6178c56620 Bug #47646: add toggle button for cleartext to PasswordBox

Successful build
Package: univention-web
Version: 3.0.5-7A~4.4.0.201903211707

UCS@school:

5a689def4 Bug #47646: YAML
e413d9bc9 Bug #47646: YAML
d380bc41e Bug #47646: use PasswordBox with reveal toggle for Passwords module
6806af903 Bug #47646: use reset as defaultAction + cleanup
1519e66ad Bug #47646: change reset password field to type password

Successful build
Package: ucs-school-umc-users
Version: 15.0.0-2A~4.4.0.201903211724
Comment 6 Ole Schwiegert univentionstaff 2019-03-26 11:05:09 CET
This bug was cloned to extract the UCS part of the changes. This bug now only verifies the changes made in UCS@school.

Bug #49099 has to be released in UCS before these changes can be introduced to UCS@school

Changelog&Advisory: OK
Package installs: OK
Password visibility toggle works: OK
Comment 7 Sönke Schwardt-Krummrich univentionstaff 2019-04-01 00:44:11 CEST
UCS@school 4.4 v2 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.4v2-de.html

If this error occurs again, please clone this bug.