Bug 48028 – Manual: class assignment is not changed if school_classes is empty

Bug 48028 - Manual: class assignment is not changed if school_classes is empty


Summary:	Manual: class assignment is not changed if school_classes is empty

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	Documentation
Version:	UCS@school 4.3
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	Sönke Schwardt-Krummrich
QA Contact:	Jürn Brodersen

URL:
Keywords:

Depends on:
Blocks:	48479
	Show dependency tree / graph

Reported:	2018-10-19 17:27 CEST by Sönke Schwardt-Krummrich
Modified:	2023-03-25 06:49 CET (History)
CC List:	4 users (show)

See Also:	48045
What kind of report is it?:	Bug Report
What type of bug is this?:	2: Improvement: Would be a product improvement
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.046
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sönke Schwardt-Krummrich

2018-10-19 17:27:51 CEST

A support ticket raised the question why class assignments of teachers are not removed when school_classes is empty.

Historical background: 
With import_user the field for the classes always had to be specified, but the assignment was done by the school via the UMC modules "Assigning teachers" and "Assigning classes". If an import was then performed, the class assignments made by the UMC modules would have been removed again.
Therefore it was implemented that the assignments are only set if the value is not empty. This behavior was adopted in ucs-school-user-import.

It is therefore (currently) a desired behavior. I have now documented the behavior in more detail in the import manual.

Comment 1 Sönke Schwardt-Krummrich

2018-10-19 17:31:05 CEST

78263f281 Bug #48028: define behaviour of school_classes

Comment 2 Daniel Tröder

2018-10-22 07:32:34 CEST

It is indeed inconsistent with other properties.
In other cases we distinguish between a) "no value" (None) because "no mapping" and b) "empty value" ('') because "has mapping but column empty".

In case a) we do not change the property.
In case b) we modify it to be empty.

Bug the (now) documented behavior is IMHO OK, because a student or teacher without school_class is very unusual.

Will a user that is deactivated, be automatically removed from its school_classes?

Comment 3 Jürn Brodersen

2018-10-25 10:12:52 CEST

ok