Bug 48141 – Move script hooks out of ucs-school-import create_*

Bug 48141 - Move script hooks out of ucs-school-import create_*


Summary:	Move script hooks out of ucs-school-import create_*

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	Import scripts
Version:	UCS@school 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 4.4 v2-errata
Assigned To:	Daniel Tröder
QA Contact:	Ole Schwiegert

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-11-13 13:02 CET by Ole Schwiegert
Modified:	2019-05-09 09:06 CEST (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ole Schwiegert

2018-11-13 13:02:35 CET

With the effort to simplify the create_* (create_ou in particular Bug #46765)
scripts in ucs-school-import the shell scripts came up again. At the moment there is no clean way to execute them and for solving mentioned Bug I had to copy the Hook implementation out of the big legacy script into the new one.

We need to discuss a new place for the scripts (ucsschool.lib?)

Comment 1 Daniel Tröder

2019-05-02 17:41:22 CEST

The duplicate hook execution code was removed.
A ucs-test verifies this now.

[4.4] 4471e16c1 Bug #48141: log hook execution
[4.4] 8840e5e80 Bug #48141: remove duplicate hook execution
[4.4] 46884df53 Bug #48141: test run-part hook execution
[4.4] 765b255ef Bug #48141: changelogs
[4.4] 61d34e118 Bug #48141: advisories

ucs-school-lib (12.1.1-5)
ucs-school-import (17.0.6-8)
ucs-test-ucsschool (6.0.0-48)

Comment 2 Daniel Tröder

2019-05-03 10:39:02 CEST

90_ucsschool/01_import_set-ou-display-name failed, because the create_ou script is supposed to be executed multiple times and thus shouldn't return an error for that.

[4.4] 057daa105 Bug #48141: repeated execution of create_ou is not an error
[4.4] 07d654b0d Bug #48141: advisory update

ucs-school-import (17.0.6-9)

Comment 3 Ole Schwiegert

2019-05-03 11:26:34 CEST

Changelog&Advisory: OK
Packages install: OK
Test passes: OK
OU creation and hook execution still works: OK

Comment 4 Sönke Schwardt-Krummrich

2019-05-08 22:26:29 CEST

UCS@school 4.4 v2 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.4v2-de.html

If this error occurs again, please clone this bug.