Bug 48303 - Errata 348: Dojo update breaks import summary grid
Errata 348: Dojo update breaks import summary grid
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - User Import UI
UCS@school 4.3
Other Linux
: P5 normal (vote)
: UCS@school 4.3 v6-errata
Assigned To: Ole Schwiegert
Jürn Brodersen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-12-07 15:48 CET by Jürn Brodersen
Modified: 2018-12-10 13:44 CET (History)
5 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 3: A User would likely not purchase the product
User Pain: 0.257
Enterprise Customer affected?: Yes
School Customer affected?:
ISV affected?:
Waiting Support: Yes
Flags outvoted (downgraded) after PO Review:
Ticket number: 2018120621000859
Bug group (optional):
Max CVSS v3 score:


Attachments
switch to iso (1.20 KB, patch)
2018-12-10 09:47 CET, Ole Schwiegert
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jürn Brodersen univentionstaff 2018-12-07 15:48:59 CET
Errata 348: Dojo update breaks import summary grid

Due to an update in dojos cldr files, the import date can't be parsed anymore

https://github.com/dojo/dojo/blame/f2ef4549faf85a6497b722d76158c5a98c5e353b/cldr/nls/de/gregorian.js#L79

The old format was "$DATE $TIME", the new one is "$DATE, $TIME" note the new comma.

If in any way possible I would prefer having the date parsing in the backend and send the date as an unix timestamp or at least in ISO format
Comment 1 Ole Schwiegert univentionstaff 2018-12-10 09:47:35 CET
Created attachment 9773 [details]
switch to iso

Adding the comma character in the python file would have been enough to fix the problem and restore the old behavior. In the proposed patch I show how the code could be a bit more easy/readable with the suggested switch to sending iso formatted time from the backend.
Comment 2 Ole Schwiegert univentionstaff 2018-12-10 10:49:59 CET
Package: ucs-school-umc-import
Version: 1.0.1-4A~4.3.0.201812101048
Branch: ucs_4.3-0
Scope: ucs-school-4.3

applied patch
Comment 3 Jürn Brodersen univentionstaff 2018-12-10 12:24:05 CET
Language set to English: Works -> OK
Language set to German: Works -> OK

YAML -> OK
Comment 4 Sönke Schwardt-Krummrich univentionstaff 2018-12-10 13:43:39 CET
UCS@school 4.3 v6 has been released.

http://docs.software-univention.de/changelog-ucsschool-4.3v6-de.html#changelog:ucsschool:2018-12-10

If this error occurs again, please clone this bug.