Bug 48315 – No userquota is shown for xfs partitions

Bug 48315 - No userquota is shown for xfs partitions


Summary:	No userquota is shown for xfs partitions

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Quota
Version:	UCS 4.3
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.3-3-errata
Assigned To:	Jannik Ahlers
QA Contact:	Jürn Brodersen

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-12-12 17:40 CET by Jürn Brodersen
Modified:	2019-01-16 13:25 CET (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.091
Enterprise Customer affected?:	Yes
School Customer affected?:
ISV affected?:
Waiting Support:	Yes
Flags outvoted (downgraded) after PO Review:
Ticket number:	2018112121000519
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jürn Brodersen

2018-12-12 17:40:18 CET

No userquota is shown for xfs partitions

repquota throws a segmentation fault with option "-F xfs". The umc module does not check the return code and instead just returns an empty list.

The filesystem autodetection seems to work fine, the filesystem option can probably removed. The long option would work as well "--format=xfs"

Comment 1 Jürn Brodersen

2018-12-12 18:10:44 CET

Already fixed in quota-tools 4.04 (ucs is at 4.03)

git://git.kernel.org/pub/scm/utils/quota/quota-tools.git
commit: ab2bf5b51a1ca14cef63e8a7a88b039f173a210a

Comment 2 Christian Völker

2018-12-12 18:30:57 CET

Customer administrator can not administer quotas.

Using command line is not suitable for them.

Comment 3 Jürn Brodersen

2019-01-08 13:24:49 CET

Replacing "-F xfs" with "--format=xfs" should be fine.

Comment 4 Jannik Ahlers

2019-01-09 11:25:39 CET

> Replacing "-F xfs" with "--format=xfs" should be fine.
I did exactly that and it works.

4.3 ---------------------
Successful build
Package: univention-quota
Version: 12.0.0-4A~4.3.0.201901091113
Branch: ucs_4.3-0
Scope: errata4.3-3

univention-quota (12.0.0-4)
78ebfa83e950 | Bug #48315: debian changelog

univention-quota (12.0.0-3)
adafa5018cef | Bug #48315: fix quota umc module for xfs file systems

univention-quota.yaml
769b591b0bd7 | Bug #48315: yaml

4.4 ---------------------
Successful build
Package: univention-quota
Version: 13.0.1-2A~4.4.0.201901091119
Branch: ucs_4.4-0
Scope: 

univention-quota (13.0.1-2)
8ca2729b591d | Bug #48315: debian changelog

univention-quota (13.0.1-1)
878b6ad56e2b | Bug #48315: fix quota umc module for xfs file systems

univention-quota.yaml
19d2eab002e0 | Bug #48315: yaml

Comment 5 Jürn Brodersen

2019-01-10 15:17:11 CET

Typo:
--version xfs -> --format=xfs

And the yaml in 4.4 can be removed

Comment 6 Jannik Ahlers

2019-01-10 16:54:05 CET

I fixed the typo and removed the yaml

univention-quota (12.0.0-4)
78ebfa83e950 | Bug #48315: debian changelog

univention-quota (12.0.0-5)
9ce95dfebbd1 | Bug #48315: fix typo

-------------
Successful build
Package: univention-quota
Version: 12.0.0-5A~4.3.0.201901101646
Branch: ucs_4.3-0
Scope: errata4.3-3

Successful build
Package: univention-quota
Version: 13.0.1-3A~4.4.0.201901101649
Branch: ucs_4.4-0

Comment 7 Jürn Brodersen

2019-01-11 13:54:16 CET

Looks good :)

I modified the quota tests (12_quota) to check xfs quota and use umc calls to check for this in the future.

Small yaml change:
[4.3-3 7a807fd071] Bug #48315: YAML

Tests: OK
Merge to 4.4: OK
YAML: OK

-> Verified

Comment 8 Arvid Requate

2019-01-16 13:25:22 CET

<http://errata.software-univention.de/ucs/4.3/404.html>