Bug 48340 – The cpu stats for nodes in uvmm aren't normalized

Bug 48340 - The cpu stats for nodes in uvmm aren't normalized


Summary:	The cpu stats for nodes in uvmm aren't normalized

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Virtualization - UVMM
Version:	UCS 4.3
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.3-3-errata
Assigned To:	Philipp Hahn
QA Contact:	Jürn Brodersen

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-12-13 12:39 CET by Jürn Brodersen
Modified:	2018-12-19 13:51 CET (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	3: A User would likely not purchase the product
User Pain:	0.137
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Proposed patch (987 bytes, patch) 2018-12-13 13:36 CET, Jürn Brodersen	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jürn Brodersen

2018-12-13 12:39:06 CET

The cpu stats for nodes in uvmm aren't normalized

We normalized the cpu stats for domains, but it seemed we overlooked the stats for nodes.

Comment 1 Jürn Brodersen

2018-12-13 13:36:10 CET

Created attachment 9778 [details]
Proposed patch

Comment 2 Philipp Hahn

2018-12-14 09:39:13 CET

Thanks for the patch; I fixed it a bit differently.

[4.3-3] 67635aa551 Bug #48340 uvmm: Normalize CPU utilization of host.
 doc/errata/staging/univention-virtual-machine-manager.yaml     | 10 ++++++++++
 .../univention-virtual-machine-manager-daemon/debian/changelog |  6 ++++++
 .../src/univention/uvmm/node.py                                |  6 +++---
 3 files changed, 19 insertions(+), 3 deletions(-)

Package: univention-virtual-machine-manager-daemon
Version: 7.0.0-18A~4.3.0.201812140932
Branch: ucs_4.3-0
Scope: errata4.3-3

[4.3-3] 718a11e5cf Bug #48340: univention-virtual-machine-manager-daemon 7.0.0-18A~4.3.0.201812140932
 ...ne-manager.yaml => univention-virtual-machine-manager-daemon.yaml} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment 3 Philipp Hahn

2018-12-14 10:36:00 CET

Also fix an error where the migration and error status were not updated correctly, as the previous state was not removed.

[4.3-3] abc6d99e42 Bug #48340 uvmm: Replace dictionaries instead of updating them
 doc/errata/staging/univention-virtual-machine-manager-daemon.yaml   | 2 +-
 .../univention-virtual-machine-manager-daemon/debian/changelog      | 6 ++++++
 .../src/univention/uvmm/node.py                                     | 4 ++--
 3 files changed, 9 insertions(+), 3 deletions(-)

Package: univention-virtual-machine-manager-daemon
Version: 7.0.0-19A~4.3.0.201812141033
Branch: ucs_4.3-0
Scope: errata4.3-3

[4.3-3] 55eae73dc2 Bug #48340: univention-virtual-machine-manager-daemon 7.0.0-19A~4.3.0.201812141033
 doc/errata/staging/univention-virtual-machine-manager-daemon.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comment 4 Jürn Brodersen

2018-12-14 14:08:42 CET

What I tested:
33% load on a domain with 3 vcpus shows 25% load on a node with 4 cores -> OK

I couldn't reliable reproduce the status problem, but I could never reproduce it with the fix and I don't see a reason why it shouldn't work :) -> OK

YAML -> OK

Comment 5 Arvid Requate

2018-12-19 13:51:12 CET

<http://errata.software-univention.de/ucs/4.3/388.html>