Bug 48460 - replace "homebrew" DES encryption code with passlib.crypto.des in univention-radius
replace "homebrew" DES encryption code with passlib.crypto.des in univention-...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Radius
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4
Assigned To: Jürn Brodersen
Sönke Schwardt-Krummrich
: interim-3
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-01-14 12:59 CET by Jürn Brodersen
Modified: 2019-03-12 13:40 CET (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jürn Brodersen univentionstaff 2019-01-14 12:59:36 CET
+++ This bug was initially created as a clone of Bug #39301 +++

We should consider replacing the DES code in univention-radius and univention-squid with passlib.utils.des.

univention-radius: univention/pyMsChapV2.py.DesEncrypt()

- convertKey()
- setOddParity()

- return pyDes.des(convertKey(key), pyDes.ECB).encrypt(data)
+ return passlib.utils.des.des_encrypt_block(key, data)



----------

passlib.utils.des was moved into passlib.crypto.des which means the api for it is stable.

A lot of the mschapv2 implementation is never used and can be removed. Only "ChallengeResponse" and "HashNtPasswordHash" is actually used.
Comment 1 Jürn Brodersen univentionstaff 2019-02-19 12:03:24 CET
[4.4-0 9a02505555] Bug #48460: Use passlib for des encryption
Comment 2 Sönke Schwardt-Krummrich univentionstaff 2019-02-27 12:05:14 CET
OK: code change
OK: functional tests → see also bug 46018
OK: changelog xml
Comment 3 Florian Best univentionstaff 2019-03-12 13:40:28 CET
UCS 4.4 has been released:
 https://docs.software-univention.de/release-notes-4.4-0-en.html
 https://docs.software-univention.de/release-notes-4.4-0-de.html

If this error occurs again, please use "Clone This Bug".