Bug 48477 – 44_well_known_sid_check.py fails to show an error description

Bug 48477 - 44_well_known_sid_check.py fails to show an error description


Summary:	44_well_known_sid_check.py fails to show an error description

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - System diagnostic
Version:	UCS 4.3
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.3-3-errata
Assigned To:	Felix Botner
QA Contact:	Jürn Brodersen

URL:	https://trello.com/c/x1L2HA8n/220-bug...
Keywords:

Depends on:	47649
Blocks:
	Show dependency tree / graph

Reported:	2019-01-16 09:58 CET by Felix Botner
Modified:	2019-02-13 13:27 CET (History)
CC List:	4 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:	Yes
School Customer affected?:
ISV affected?:
Waiting Support:	Yes
Flags outvoted (downgraded) after PO Review:
Ticket number:	2019010321000187
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Felix Botner

2019-01-16 09:58:54 CET

+++ This bug was initially created as a clone of Bug #47649 +++

If we receive diagnostic errors from customer systems, it is hard to understand which commands have been executed.

For example if you change the /etc/machine.secret and re-run the checks you get for the failed ssh connection only the following message in UMC:
 {'desc': 'Invalid credentials'}

The logfile shows only:
14.03.18 18:51:16.005  MODULE      ( PROCESS ) : Running <univention.management.console.modules.diagnostic.Plugin object at 0x7fbac916f150>

It would be helpful if the errors are written to the logfile. It would also be extremely good if the commands are written to the logfile, for example:
 Try univention-ssh /etc/machine.secret backup$@master.domain

Comment 1 Felix Botner

2019-01-16 09:59:02 CET

 Traceback (most recent call last): File "/usr/lib/pymodules/python2.7/univention/management/console/modules/diagnostic/__init__.py", line 275, in execute result = execute(umc_module, **kwargs) File "/usr/lib/pymodules/python2.7/univention/management/console/modules/diagnostic/plugins/44_well_known_sid_check.py", line 176, in run MODULE.error(description='\n'.join(str(x) for x in check_errors)) TypeError: error() got an unexpected keyword argument 'description'

Comment 2 Felix Botner

2019-01-16 10:12:06 CET

bb9ab7770e540ae076c75e0e02b28516a55669b1 -
univention-management-console-module-diagnostic
2fd046a2834406a2f90159c463e504657c4ca06e - yaml
97f4670fd7dfefc1c87bd6c553bdc942a7af8e1e - 4.4-0 merge
2f8b17a69dd378f8c05c287d05ecf2dcd5435cfd - 4.4-0 merge

Comment 3 Jürn Brodersen

2019-01-16 11:10:05 CET

What I tested:

Error in 44_well_known_sid_check.py -> No more Traceback -> OK
4.4 merge -> OK

YAML change: [4.3-3 8b861edbb6] Bug #48477, #47650: yaml

-> Verified

Comment 4 Erik Damrose

2019-02-13 13:27:27 CET

<http://errata.software-univention.de/ucs/4.3/425.html>