Bug 48492 - Let's Encrypt virtualhosts break https for Docker apps
Summary: Let's Encrypt virtualhosts break https for Docker apps
Status: CLOSED FIXED
Alias: None
Product: UCS
Classification: Unclassified
Component: Let's Encrypt
Version: UCS 4.3
Hardware: Other Linux
: P5 normal
Target Milestone: ---
Assignee: Jürn Brodersen
QA Contact: Jannik Ahlers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-18 10:32 CET by Jannik Ahlers
Modified: 2019-03-07 14:59 CET (History)
7 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 4: A User would return the product
User Pain: 0.343
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Customer ID:
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jannik Ahlers univentionstaff 2019-01-18 10:32:27 CET 
A user from the forum noticed that with the new version of the Let's Encrypt app,
https is broken for some apps.
 The Proxy directives for Docker Apps are not correctly included in the new let’s encrypt VirtualHost configuration, so Docker Apps cannot be reached when accessed via the domain configured for the App.
https://help.univention.com/t/suitecrm-not-accessible-via-https-after-update/10950

The problem is with these lines in /etc/apache2/sites-enabled/default-ssl.conf:

ProxyPass /suitecrm https://127.0.0.1:40001/suitecrm retry=0
/suitecrm https://127.0.0.1:40001/suitecrm
Comment 1 Felix Botner univentionstaff 2019-01-18 10:42:06 CET 
I have deactivated the current app (letsencrypt_20190110145256).

Please update the package and the current app and re release the current version 1.2.2-6 (no app update)
Comment 2 Jürn Brodersen univentionstaff 2019-01-18 11:39:23 CET 
[4.3 8b762a9] Bug #48492: Fix let's encrypt virtual host config for docker apps
Comment 3 Jürn Brodersen univentionstaff 2019-01-18 11:48:17 CET 
New Version is uploaded to the test appcenter
Comment 4 Jannik Ahlers univentionstaff 2019-01-18 12:27:06 CET 
Code - OK
Installation - OK
generation of conffile - OK
docker app works (tested with dudle) - OK
Comment 5 Felix Botner univentionstaff 2019-01-18 13:44:13 CET 
(old) current version fixed (1.2.2-6) and we released a new version (1.2.2-8) with the same package/fix, so that everybody with the broken app can easily update to the new version.