Bug 48721 – At two places uldap uses ReconnectLDAPObject with default retry_max=1

Bug 48721 - At two places uldap uses ReconnectLDAPObject with default retry_max=1


Summary:	At two places uldap uses ReconnectLDAPObject with default retry_max=1

Status:	NEW

Product:	UCS
Classification:	Unclassified
Component:	UDM (Generic)
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	UMC maintainers
QA Contact:	UMC maintainers

URL:
Keywords:

Depends on:	32617
Blocks:
	Show dependency tree / graph

Reported:	2019-02-20 17:59 CET by Arvid Requate
Modified:	2021-05-03 21:58 CEST (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
retry_ReconnectLDAPObject.patch (2.33 KB, patch) 2019-02-20 17:59 CET, Arvid Requate	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arvid Requate

2019-02-20 17:59:16 CET

Created attachment 9850 [details]
retry_ReconnectLDAPObject.patch

I just grepped though our UCS repo and found two cases (in both uldap.py modules) where ReconnectLDAPObject is used with the default value of 1 for retry_max. In that case the reconnect is tried immediately after the initial connect failed, without any waiting. See attached patch proposal.

Comment 1 Sönke Schwardt-Krummrich

2019-02-21 09:16:02 CET

I just noticed a "time.sleep(60)" within the diff. Isn't that a little redundant now?

Comment 2 Sönke Schwardt-Krummrich

2019-02-21 09:18:20 CET

We should also check if the change negatively affects code outside the lib (e.g. longer runtime because the exception is now thrown after 10 unsuccessful attempts).