Bug 48992 - shellcheck: quoting bugs
Summary: shellcheck: quoting bugs
Status: RESOLVED WONTFIX
Alias: None
Product: UCS
Classification: Unclassified
Component: General
Version: UCS 4.4
Hardware: Other Linux
: P5 normal
Target Milestone: ---
Assignee: UCS maintainers
QA Contact: UCS maintainers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-14 13:09 CET by Arvid Requate
Modified: 2024-06-27 12:09 CEST (History)
0 users

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Customer ID:
Max CVSS v3 score:

Attachments
SC2046_and_SC2086_quoting_issues.patch (18.29 KB, patch)
2019-03-14 13:09 CET, Arvid Requate 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Requate univentionstaff 2019-03-14 13:09:40 CET 
Created attachment 9924 [details]
SC2046_and_SC2086_quoting_issues.patch

I used shellcheck on git/ucs to look for SC2046 and SC2086 quoting bugs:

find \( -name "*.inst" -o -name "*.sh" -o -name "*.postinst" \) -exec shellcheck {} \;

See attached patch for the most severe cases I found. I neglected missing quoting for things like "hostname.$domainname" etc.
Comment 1 Jan-Luca Kiok univentionstaff 2024-06-27 12:09:51 CEST 
This issue has been filed against UCS 4.4.

UCS 4.4 is out of general maintenance and components may have vastly changed in later releases. Thus, this issue is now being closed.

If this issue still occurs in newer versions, please use "Clone this bug" or reopen this issue. In this case please provide detailed information on how this issue is affecting you.