Bug 48992 – shellcheck: quoting bugs

Bug 48992 - shellcheck: quoting bugs


Summary:	shellcheck: quoting bugs

Status:	NEW

Product:	UCS
Classification:	Unclassified
Component:	General
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	UCS maintainers
QA Contact:	UCS maintainers

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-03-14 13:09 CET by Arvid Requate
Modified:	2019-03-14 13:10 CET (History)
CC List:	0 users

See Also:	48989
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
SC2046_and_SC2086_quoting_issues.patch (18.29 KB, patch) 2019-03-14 13:09 CET, Arvid Requate	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arvid Requate

2019-03-14 13:09:40 CET

Created attachment 9924 [details]
SC2046_and_SC2086_quoting_issues.patch

I used shellcheck on git/ucs to look for SC2046 and SC2086 quoting bugs:

find \( -name "*.inst" -o -name "*.sh" -o -name "*.postinst" \) -exec shellcheck {} \;

See attached patch for the most severe cases I found. I neglected missing quoting for things like "hostname.$domainname" etc.