Bug 49143 – Migrate base/univention-updater to dh_python2

Bug 49143 - Migrate base/univention-updater to dh_python2


Summary:	Migrate base/univention-updater to dh_python2

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	Update - univention-updater
Version:	UCS 4.4
Hardware:	All Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-2-errata
Assigned To:	Florian Best
QA Contact:	Felix Botner

URL:
Keywords:

Depends on:	49161
Blocks:	28497
	Show dependency tree / graph

Reported:	2019-03-28 10:26 CET by Florian Best
Modified:	2019-11-20 13:26 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2019-03-28 10:26:11 CET

The package base/univention-updater should be migrated to use dh_python instead of python-support.

Migration-Guide: https://hutten.knut.univention.de/mediawiki/index.php/Python_DebHelper_Migration

Comment 1 Florian Best

2019-10-15 11:13:25 CEST

Patch available in git:dh-python/base

Comment 2 Florian Best

2019-11-05 18:14:21 CET

Should we split univention-updater into univention-updater, python-univention-updater, python3-univention-updater ?

Comment 3 Florian Best

2019-11-08 15:18:49 CET

The package has been split into univention-updater, python-univention-updater, python3-univention-updater.

univention-updater.yaml
aa3c75c684a3 | YAML Bug #49143

univention-updater (14.0.2-6)
167e25f87583 | Bug #49143: upgrade hook directory
966fcfa2d33d | Bug #49143: split into python{,3}-univention-updater
af8e96ff2f17 | Bug #49143: futurize univention-updater
a0a27fe0b953 | Bug #49143: migrate univention-updater to dh_python

Comment 4 Felix Botner

2019-11-19 12:56:49 CET

I think this breaks the (umc) updater hooks. Hooks are copied from /usr/share/pyshared/univent... to /usr/lib/python2.7/dist-... during the update, but only if the hook file is not part of a package. So what happens

 * if the hook file is part of a package (apart from a warning message
   during the errata update)
 * if somebody installs a updater hooks after the univention-updater
   package update

Comment 5 Philipp Hahn

2019-11-19 15:02:10 CET

(In reply to Felix Botner from comment #4)
> I think this breaks the (umc) updater hooks. Hooks are copied from
> /usr/share/pyshared/univent... to /usr/lib/python2.7/dist-... during the
> update, but only if the hook file is not part of a package. So what happens
> 
>  * if the hook file is part of a package (apart from a warning message
>    during the errata update)
>  * if somebody installs a updater hooks after the univention-updater
>    package update

As discussed:
[4.4-2] 416ea083a4 Bug #49143: univention-updater 14.0.2-7A~4.4.0.201911191439
[4.4-2] 9733460054 Bug #49143 up: Fix translation of Updater
[4.4-2] 9b67df10aa Bug #49143 up: Support legacy hook directory
[4.4-2] 2fbd9709f1 Bug #49143 up: Fix DH substitutions

Package: univention-updater
Version: 14.0.2-7A~4.4.0.201911191439
Branch: ucs_4.4-0
Scope: errata4.4-2

QA: See comment from git:9b67df10aa

Comment 6 Felix Botner

2019-11-19 16:38:52 CET

OK - update
OK - package content
OK - univention-upgrade still works
OK - dh_python
OK - hook documentation
OK - hook in old hook-directory
OK - hook in new hook-directory

OK - yaml

Comment 7 Arvid Requate

2019-11-20 13:26:45 CET

<http://errata.software-univention.de/ucs/4.4/359.html>