Bug 49392 - Cherry-Pick python3-pam from ubuntu
Cherry-Pick python3-pam from ubuntu
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Florian Best
Arvid Requate
:
Depends on:
Blocks: 49060
  Show dependency treegraph
 
Reported: 2019-04-29 17:38 CEST by Florian Best
Modified: 2021-05-25 16:00 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
patch (20.17 KB, patch)
2019-06-27 02:26 CEST, Florian Best
Details | Diff
PAM.py (9.81 KB, text/x-python)
2020-06-23 13:44 CEST, Florian Best
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2019-04-29 17:38:02 CEST
We should cherry-pick python3-pam from ubuntu. It's not yet available in debian.

We need this for univention-management-console.

https://packages.ubuntu.com/xenial/python3-pam
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680148
Comment 1 Philipp Hahn univentionstaff 2019-04-30 08:01:28 CEST
(In reply to Florian Best from comment #0)
> We should cherry-pick python3-pam from ubuntu. It's not yet available in
> debian.

Please do not pick source packages from arbitrary sources without contacting the Security team first!

PS: The projects are named "Debian" and "Ubuntu" with a capital first letter.
Comment 2 Florian Best univentionstaff 2019-06-27 02:26:10 CEST
Created attachment 10091 [details]
patch

These are the changes. They work and look good.
Comment 3 Arvid Requate univentionstaff 2019-07-01 14:31:31 CEST
Please add to https://hutten.knut.univention.de/mediawiki/index.php/Security_Updates#Spezielle_Pakete when doing this.
Comment 4 Jürn Brodersen univentionstaff 2020-03-02 15:42:22 CET
We might also want to evaluate python-pampy https://packages.debian.org/source/buster/python-pampy from https://github.com/FirefighterBlu3/python-pam
Comment 5 Florian Best univentionstaff 2020-06-08 18:13:45 CEST
Cherry-Picked from ubuntu xenial and added to the Special security packages wiki page.

Package: python-pam
Version: 0.4.2-13.2ubuntu2A~5.0.0.202006081810
Comment 6 Arvid Requate univentionstaff 2020-06-09 11:32:59 CEST
Please pull from focal.
Comment 7 Philipp Hahn univentionstaff 2020-06-09 16:12:38 CEST
PyPAM is dead:
- Debian never packaged anything newer than 0.4.2
- The Debian maintainer is MIA
- There only have been two NMUs for Debian-8-Jessie and Debian-9-Stretch to keep the package minimally alive. It will be removed from Debian-11-Bullseye due to the missing Python3 binding anyway.
- Gentoo had 0.5.0-rc4 but also flags it as unmaintained
- CentOS-7 also has 0.5.0
- The upstream source <http://www.pangalactic.org/PyPAM> no longer exists.

There only seems to be one use of python-pam, which is
management/univention-management-console/debian/control: python-pam,

Maybe switch to python-pampy ?
Comment 8 Florian Best univentionstaff 2020-06-09 16:34:38 CEST
(In reply to Philipp Hahn from comment #7)
> Maybe switch to python-pampy ?

python-pampy only provides pam_authenticate, pam_setcred.
We need additionally: pam_acct_mgmt, pam_chauthtok, pam_putenv.
It also doesn't have the possibility to set an own conversation function.

I could write a patch for python-pampy (ctypes), which adds every needed functionality, if wanted.
Comment 9 Florian Best univentionstaff 2020-06-23 13:44:52 CEST
Created attachment 10404 [details]
PAM.py

I created a full featured PAM compatible library using ctypes.
Comment 10 Florian Best univentionstaff 2020-07-13 13:56:45 CEST
(In reply to Philipp Hahn from comment #7)
> PyPAM is dead:

Russell Stuart - 2020-04-05
"""
I'm just letting everybody know now the tests work, I've started intergrating all the changes for a new release.
"""
https://sourceforge.net/p/pam-python/tickets/5/
Comment 11 Arvid Requate univentionstaff 2021-02-25 13:42:04 CET
Re-imported from focal:

Package: python-pam
Version: 0.4.2-13.2ubuntu8A~5.0.0.202102251339
Branch: ucs_5.0-0
Comment 12 Arvid Requate univentionstaff 2021-03-02 16:03:32 CET
485f289611 | UCS-5 changelog
Comment 13 Florian Best univentionstaff 2021-05-25 16:00:09 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".