Univention Bugzilla – Bug 49543
error handling for "copy /etc/machine.secret into container"
Last modified: 2019-06-05 15:56:00 CEST
_start_docker_image writes the /etc/machine.secret into the container overlay path. If that fails the installation process stops and leaves the app in an undefiend state (neither remove nor re-install is possible now). We should not break at this point, but add error handling or ignore the error.
> app in an undefiend state (neither remove nor re-install is possible now). This is not true, the app is de-installed. Better error handling would be good anyway.
6ca5659aa3d0e6a77230210c40c3972ce5f239e2 - univention-appcenter 0fc2d0ae57aedac9fba31b701652e63a8c59d751 - yaml
OK, in my tests the error message is more or less doubled, but maybe in "real world errors"... better safe than sorry.
This breaks the openid-connect-provider App. This app starts the container read-only and now the docker-cp fails.
ok, back to creating the file in the overlay directory, if that fails raise DockerCouldNotStartContainer instead of the original exception-
Does the error also add some value to the DockerCouldNotStartContainer error? It would be good to get additional feedback like for example "Failed to write /etc/machine.secret to container".
(In reply to Nico Gulden from comment #6) > Does the error also add some value to the DockerCouldNotStartContainer > error? It would be good to get additional feedback like for example "Failed > to write /etc/machine.secret to container". yes, in case the creation of the machine.secret fails, DockerCouldNotStartContainer is raised with a message containing the exception and docker.logs from the container.
OK, works
<http://errata.software-univention.de/ucs/4.4/141.html>