Bug 49679 - S4-Connector breaks SOA records by always appending a missing dot to short mname
S4-Connector breaks SOA records by always appending a missing dot to short mname
Status: NEW
Product: UCS
Classification: Unclassified
Component: S4 Connector
UCS 4.4
Other Linux
: P5 normal (vote)
: ---
Assigned To: Samba maintainers
Samba maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-06-18 15:00 CEST by Arvid Requate
Modified: 2022-10-11 18:21 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
patch (git:fbest/49679-dns-append-dot-s4-connector) (1.50 KB, patch)
2019-06-18 15:05 CEST, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Requate univentionstaff 2019-06-18 15:00:41 CEST
The S4-Connector breaks SOA records by always appending a missing dot to short mname. This was found by checking test case

67_udm-dns/01_dns_forward_zone_check_soa_record
Comment 1 Florian Best univentionstaff 2019-06-18 15:05:14 CEST
Created attachment 10069 [details]
patch (git:fbest/49679-dns-append-dot-s4-connector)
Comment 2 Florian Best univentionstaff 2019-06-27 11:55:34 CEST
Added a workaround for that problem in the test cases:

commit f7977829d54d0e4de5d055974744b3a8a8e33b89
    Bug #49679: temporarily always append a dot to nSRecord entries

 test/ucs-test/tests/67_udm-dns/04_dns_forward_zone_creation_set_nameserver         | 2 +-
 test/ucs-test/tests/67_udm-dns/05_dns_forward_zone_modification_set_nameserver     | 4 ++--
 test/ucs-test/tests/67_udm-dns/06_dns_forward_zone_creation_append_nameservers     | 2 +-
 test/ucs-test/tests/67_udm-dns/07_dns_forward_zone_modification_append_nameservers | 2 +-
 test/ucs-test/tests/67_udm-dns/52_dns_reverse_zone_creation_set_nameserver         | 2 +-
 test/ucs-test/tests/67_udm-dns/53_dns_reverse_zone_modification_set_nameserver     | 6 +++---
 test/ucs-test/tests/67_udm-dns/54_dns_reverse_zone_creation_append_nameserver      | 2 +-
 test/ucs-test/tests/67_udm-dns/55_dns_reverse_zone_modification_append_nameserver  | 2 +-
 test/ucs-test/tests/67_udm-dns/68_dns_forward_zone_modification_remove_nameserver  | 2 +-
 test/ucs-test/univention/testing/strings.py
Comment 3 Florian Best univentionstaff 2019-07-01 11:01:35 CEST
And some more tests:

ucs-test (9.0.2-111)
af772c360f1c | Bug #49679: temporarily always append a dot to nSRecord entries
d75e836205fc | Bug #49679: temporarily always append a dot to nSRecord entries
Comment 4 Florian Best univentionstaff 2019-07-15 16:46:34 CEST
Same applies for ptr_record of dns/ptr_record objects.

ucs-test (9.0.3-2)
426855c0f65c | Bug #49679: fix ptr_record race condition
Comment 5 Florian Best univentionstaff 2019-08-30 10:07:27 CEST
Another workaround for ucs-test:

ucs-test (9.0.3-34)
4d0c7da6bc74 | Bug #49679: fix 61_dns_ptr_modification_append_records and 63_dns_ptr_modification_remove_records in S4-Connector environments