Bug 49907 - Dialog when closing the computer room module during a class test
Dialog when closing the computer room module during a class test
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Computer room
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v3
Assigned To: Ole Schwiegert
Jürn Brodersen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-07-23 08:43 CEST by Ole Schwiegert
Modified: 2019-09-26 10:32 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ole Schwiegert univentionstaff 2019-07-23 08:43:48 CEST
As a teacher I would like to receive a question when closing the computer room module during a class test if I would like to finish the class test in order not to let the class test continue inadvertently.

Further requirements:
- Text pop-up dialog:
Title: Close
Body: Do you really want to close the class test mode?
The class work mode will then be closed. All related class test documents are collected from the student home directories and stored in the corresponding class test directory below your home directory.
If you do so WITHOUT EXITING, you can open the computer room module again later and return to the class test mode. Please do not miss to finish the class test.
- Pop-Up Dialog Options CANCEL, EXIT CLASS WORK, WITHOUT EXIT Continue
- Preselection: FINISH CLASS WORK

Questions to be answered:
- What happens if I change the "focus"? E.g. another module in the tab.
- What happens if I unsubscribe?
- What happens if I am unsubscribed?

Acceptance criteria:
1 Assuming I am in class test mode in the computer room module, when I click on CLOSE a pop-up "Close" with the above options appears.
Assuming the pop-up dialog appears, the CANCEL link takes me back to the Computer Room Module/Class Work Mode.
Assuming the pop-up dialog appears, the link EXIT CLASS WORK takes me back to the computer room module and finishes the class test first.
Assuming the pop-up dialog appears, the link WITHOUT EXIT PROGRESS leads me to the UMC home view without exiting the class test.
Comment 1 Ole Schwiegert univentionstaff 2019-07-26 14:38:11 CEST
Implemented on fb/4.4/49907
Comment 2 Jürn Brodersen univentionstaff 2019-07-29 09:32:55 CEST
Reopen:
Missing translation: "Close computerroom module"
random "body =" line. Copy paster error? ;)
jshint complains about some missing semicolons
It's not possible to close the module if the "Choose room" dialog was aborted instead of choosing a room.
Comment 3 Ole Schwiegert univentionstaff 2019-07-29 10:06:24 CEST
No idea how the fragment slipped into the commit.. Removed
Translation added
Semicoli added
Fixed no room select problem
Comment 4 Jürn Brodersen univentionstaff 2019-07-29 11:03:53 CEST
What I tested:
Closed module without exam -> No warning -> OK
Closed module with exam -> Warning -> OK
Closed module without an opened room -> OK

-> Ready for merge -> Reopen for merge
Comment 5 Ole Schwiegert univentionstaff 2019-09-12 09:18:44 CEST
Package: ucs-school-umc-computerroom
Version: 11.0.0-5A~4.4.0.201909120915
Branch: ucs_4.4-0
Scope: ucs-school-4.4

Package: ucs-test-ucsschool
Version: 6.0.49A~4.4.0.201909120918
Branch: ucs_4.4-0
Scope: ucs-school-4.4
Comment 6 Jürn Brodersen univentionstaff 2019-09-19 18:37:43 CEST
Merge -> ok
YAML -> OK

Johannes has helped me with the test:
[4.4 8a27bfcd1] Bug #49907: fix 91_ucsschool-selenium/03_computerroom_endExam

-> Verified
Comment 7 Sönke Schwardt-Krummrich univentionstaff 2019-09-26 10:32:52 CEST
UCS@school 4.4 v3 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.4v3-de.html

If this error occurs again, please clone this bug.