Bug 49958 – Windows computers without univentionServerRole=windows_client aren't found via UDM anymore

Bug 49958 - Windows computers without univentionServerRole=windows_client aren't found via UDM anymore


Summary:	Windows computers without univentionServerRole=windows_client aren't found vi...

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UDM (Generic)
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-1-errata
Assigned To:	Arvid Requate
QA Contact:	Jürn Brodersen

URL:
Keywords:

Depends on:	48390
Blocks:
	Show dependency tree / graph

Reported:	2019-08-02 14:25 CEST by Florian Best
Modified:	2019-10-01 12:24 CEST (History)
CC List:	5 users (show)

See Also:	50297
What kind of report is it?:	Bug Report
What type of bug is this?:	5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	5: Blocking further progress on the daily work
User Pain:	0.286
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	2019071921000299
Bug group (optional):	External feedback, Regression
Max CVSS v3 score:

Flags:	best: Patch_Available+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2019-08-02 14:25:40 CEST

A regression caused that computers/windows and computers/domaincontroller_windows is not found anymore in UDM if it doesn't have the univentionServerRole attribute set.
This is the case for computer objects created before UCS 3.0.

+++ This bug was initially created as a clone of Bug #41659 +++

There is a lot of redundant code in the computers/* UDM handlers.
Especially the open/_ldap_addlist/_ldap_modlist/_ldap_{pre,post}_{create,modify,delete} methods are nearly the same in every handler.

We should outsource that code into external classes/methods/functions.

Comment 1 Florian Best

2019-08-02 14:31:36 CEST

Patch in git:fbest/49958-fix-windows-lookup branch.

Comment 2 Florian Best

2019-08-02 17:21:31 CEST

It's acutally Bug #48390 (git: b0a692935f7733fcae4ff1c4c5b8649e6d1db115) which caused this.

Comment 3 Christian Völker

2019-08-05 09:36:05 CEST

Wouldn't it be better to add the attribute to the computers? At least additionally?

Comment 4 Florian Best

2019-08-08 14:32:57 CEST

(In reply to Christian Völker from comment #3)
> Wouldn't it be better to add the attribute to the computers? At least
> additionally?
Yes, this would be more future proof. But we definately should fix it, too.

Comment 5 Florian Best

2019-08-13 07:42:49 CEST

Probably also the reason for: https://help.univention.com/t/mdb-database-full-and-stops-replication/12648/6

Comment 6 Arvid Requate

2019-09-02 18:56:01 CEST

1ad741b3a4 | New diagnostic plugin
30f91a9c73 | Fix typos
46438288f3 | Advisory

Comment 7 Arvid Requate

2019-09-02 21:52:12 CEST

eff08e603c | Fixes in response to core review feedback
3b1948fe60 | Advisory

Comment 9 Jürn Brodersen

2019-09-03 14:27:53 CEST

What I tested:
computers/windows and computers/domaincontroller_windows with univentionServerRole -> No warning -> OK

computers/windows and computers/domaincontroller_windows without univentionServerRole -> Warning -> OK

Fix computers/windows and computers/domaincontroller_windows without univentionServerRole -> OK

Reopen:
If fixable and unfixable objects exists both are counted for the migrate button.

Comment 10 Arvid Requate

2019-09-03 15:41:21 CEST

b8280a4b18 | More qa feedback
417627991a | Advisory Update

Comment 11 Jürn Brodersen

2019-09-03 17:19:32 CEST

Looks good now :)
YAML -> OK

-> Verified

Comment 12 Arvid Requate

2019-09-04 15:48:14 CEST

<http://errata.software-univention.de/ucs/4.4/251.html>