Bug 50008 - Class assignment at second school returns error
Class assignment at second school returns error
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Classes / Teachers / Workgroup assignment
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v4-errata
Assigned To: Jürn Brodersen
Daniel Tröder
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-08-14 12:19 CEST by Nico Stöckigt
Modified: 2019-09-26 10:32 CEST (History)
6 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.429
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support: Yes
Flags outvoted (downgraded) after PO Review:
Ticket number: 2019081321000879
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Stöckigt univentionstaff 2019-08-14 12:19:41 CEST
When there is a teacher at S1 and S2, while S1 is the primary school, the class assignment at S2 isn't working.

Assigned classes aren't displayed and when trying to add an additional class the message appears:

==> /var/log/univention/management-console-module-schoolgroups.log <==
14.08.19 11:45:40.446  MODULE      ( PROCESS ) : Die Anfrage enthält keine Schule. Um Fortzufahren, muss zuerst eine Schule erstellt werden, dazu kann das "Schulen"-Modul verwendet werden.

==> /var/log/univention/management-console-web-server.log <==
14.08.19 11:45:40.448  MAIN        ( PROCESS ) : CPCommand (192.168.0.247:60304) response status code: 503
14.08.19 11:45:40.448  MAIN        ( PROCESS ) : CPCommand (192.168.0.247:60304) response message: Die Anfrage enthält keine Schule. Um Fortzufahren, muss zuerst eine Schule erstellt werden, dazu kann das "Schulen"-Modul verwendet werden.
14.08.19 11:45:40.448  MAIN        ( PROCESS ) : CPCommand (192.168.0.247:60304) response result: {u'no_school_found': True}
14.08.19 11:45:40.448  MAIN        ( PROCESS ) : CPCommand (192.168.0.247:60304) response error: {u'traceback': None, u'command': u'classes'}

----------------------------------------

Jürn nailed it down to a missing school-attribute in JS; probably due to a missing ComboBox in the class assignment form.
It appears the UMC/module didn't realize there are multiple schools.
Comment 1 Michel Smidt 2019-09-02 14:51:38 CEST
Is the current top item in the priority list for the next sprint planning.
Comment 2 Jürn Brodersen univentionstaff 2019-09-11 16:06:49 CEST
Notes for me and QA:

The very similar teacher assignment module seems to be working fine.

Using a domain admin does not throw the error mentioned in comment 0, but neither is the teacher added to the class.

Using a school admin for S2 does throw the error.
Comment 3 Jürn Brodersen univentionstaff 2019-09-17 11:46:06 CEST
[4.4 28f80bff9] Bug #50008: Fix class assignment for multi school environments
[4.4 8d1c5f6b0] Bug #50008: add tests (teacher/class assignemt)
[4.4 5991e117d] Bug #50008: changelog (ucs-school-umc-groups)
[4.4 660321921] Bug #50008: changelog (ucs-test-ucsschool)
[4.4 7750c1a00] Bug #50008: yaml
[4.4 1926436f9] Bug #50008: yaml

Successful build
Package: ucs-school-umc-groups
Version: 9.0.0-1A~4.4.0.201909171127
Branch: ucs_4.4-0
Scope: ucs-school-4.4

Successful build
Package: ucs-test-ucsschool
Version: 6.0.50A~4.4.0.201909171136
Branch: ucs_4.4-0
Scope: ucs-school-4.4


Note:
After consultation with our PO I also made the school visible for classes.
Comment 4 Daniel Tröder univentionstaff 2019-09-17 17:33:46 CEST
OK: code changes
OK: test fails before update and succeeds after the update
OK: advisory
Extra thumbsup for very nice tests.
Comment 5 Sönke Schwardt-Krummrich univentionstaff 2019-09-26 10:32:45 CEST
UCS@school 4.4 v3 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.4v3-de.html

If this error occurs again, please clone this bug.