Bug 50033 - S4-Connector: Synchronize c,st,initials, physicalDeliveryOfficeName, postOfficeBox, preferredLanguage starting in UCS 4.4-2
S4-Connector: Synchronize c,st,initials, physicalDeliveryOfficeName, postOffi...
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: S4 Connector
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-2
Assigned To: Julia Bremer
Erik Damrose
:
: 40243 48081 (view as bug list)
Depends on: 50080 49008 49092 50073 56528
Blocks: 50186 50278
  Show dependency treegraph
 
Reported: 2019-08-20 20:10 CEST by Florian Best
Modified: 2023-09-05 07:30 CEST (History)
9 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2018102921000597
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2019-08-20 20:10:07 CEST
initials, physicalDeliveryOfficeName, postOfficeBox, preferredLanguage should be synchronized.

We need to change this in a minor release because existing extended attributes for these properties might break behavior.

+++ This bug was initially created as a clone of Bug #49092 +++

We should check which additional attributes would be useful to synchronize between UDM/OpenLDAP and Samba/AD.

When updating existing UCS installations, care must be taken to

1. not overwrite live attribute values
2. synchronize all new attribute values

This update handling may need more effort than the attribute mapping itself, so it makes sense to do this once for a bunch of additional attributes.

I'll add a couple of old bugs to the See Also field.


+++ This bug was initially created as a clone of Bug #49008 +++

+++ This bug was initially created as a clone of Bug #49007 +++

A customer wanted to have the LDAP attribute employeeNumber synchronized to an attribute of the same name in AD and S4. I think it makes sense to integrate the resulting patch into the default mapping.
Comment 1 Florian Best univentionstaff 2019-08-20 20:17:58 CEST
*** Bug 48081 has been marked as a duplicate of this bug. ***
Comment 2 Florian Best univentionstaff 2019-08-20 20:19:37 CEST
(In reply to Florian Best from comment #1)
> *** Bug 48081 has been marked as a duplicate of this bug. ***
(In reply to Nico Stöckigt from comment #0)
> The MS/AD attribute 'Initials'
> (https://docs.microsoft.com/en-us/windows/desktop/adschema/a-initials)
> serves a reasonable purpose and it might be very useful in key scenarios to
> have this attribute available and editable via UMC.

Please note, that there is also the wish to add this property to the UMC layout!
Comment 3 Nico Stöckigt univentionstaff 2019-08-21 11:26:18 CEST
After this is a Feature-Request, which is requested quite often by customers, what are the odds to add this to the product?
Comment 4 Arvid Requate univentionstaff 2019-08-21 15:14:38 CEST
It has been implemented, we just decided to not do it in an errata update, because this requires new properties to be added to UDM and a customer may theoretically have created an extended attribute to make an LDAP-attibute available. We need a changelog to inform the users for this *before* updating, so we decided to postpint this to a release update, either 4.4-2 or 4.5-0.
Comment 5 Arvid Requate univentionstaff 2019-08-22 13:47:14 CEST
We also postponed the synchronizarion of UDM property "country", because there is a quirk in the definition of this UDM property: It ist mapped to LDAP attribute "st" instead of "c". To get out of this we would also need to create a UDM property to sync "c". And we probably should change the UDM poperty names to match the LDAP attributes. After that, we may add them to the S4-Connector mapping (st<->st and c<->c, instead of "st<->c").
Comment 6 Julia Bremer univentionstaff 2019-09-12 11:06:51 CEST
Fixed in branch jbremer/bug50033, 

New udm attributes that will be mapped by the s4connector:
initials, physicalDeliveryOfficeName, postOfficeBox, preferredLanguage, preferredDeliveryMethod

These attributes existed before and will now be mapped by the s4-connector:
jpegPhoto, secretary, userCertificate



The adjusted packages are:
univention-python
univention-s4-connector
univention-directory-manager-modules
ucs-test
Comment 7 Julia Bremer univentionstaff 2019-09-12 12:34:28 CEST
I disabled the synchronization of secretary in jbremer/bug50033 in commit
f6ac35b752d0faa5fd5945ad5c3bbbd54147d78e

because it causes rejects if the secretar DN does not exist in S4.
Comment 8 Felix Botner univentionstaff 2019-09-12 16:51:01 CEST
OK - univention-python
OK - univention-directory-manager-modules
OK - secretary not synced for now (must be existing DN in samba)
OK - initials max 6 characters (as in AD)
OK - install (sync all new attrs)
OK - branchtest
OK - new ucs-tests
OK - update (ignore all new attrs in sync)
OK - ignore preferredDeliveryMethod > 9 (<0)  from samba

ready for merge to 4.4-2
Comment 9 Julia Bremer univentionstaff 2019-09-19 10:58:30 CEST
I merged my changes to 4.4-2:


757f3158e0 Bug #40243: fix s4connector decodes every attribute to unicode which breaks binary attributes, join Decode-ignorelists and remove previous workarounds
f0f64915db Bug #50033: Changelog

Successful build
Package: univention-s4-connector
Version: 13.0.2-44A~4.4.0.201909190933
Branch: ucs_4.4-0
Scope: ucs4.4-2

Successful build
Package: univention-python
Version: 12.0.0-16A~4.4.0.201909190937
Branch: ucs_4.4-0
Scope: ucs4.4-2

Successful build
Package: univention-directory-manager-modules
Version: 14.0.13-17A~4.4.0.201909190939
Branch: ucs_4.4-0
Scope: ucs4.4-2
User: jbremer


Not sure about the wording in the changelog yet.
Comment 10 Julia Bremer univentionstaff 2019-09-19 13:16:24 CEST
Package: univention-s4-connector
Version: 13.0.2-45A~4.4.0.201909191314
Branch: ucs_4.4-0
Scope: ucs4.4-2


bfff23fc93 Bug #50033: Minor coding improvements
Comment 11 Felix Botner univentionstaff 2019-09-19 17:33:37 CEST
OK - 4.4-2 update
OK - 4.4-2 installation

TODO jenkins test
TODO changelog/release notes
Comment 12 Erik Damrose univentionstaff 2019-09-20 09:08:29 CEST
reopen: A test failed for the first time this morning, probably due to commits at this bug?

120sync_create_and_modify_ucs_user: Zeile 160: --append: Kommando nicht gefunden.
Comment 13 Erik Damrose univentionstaff 2019-09-23 10:06:36 CEST
I see that there is a commit from 2019-09-20 17:06
7b057478 Fix 120_sync_create_and_modify_ucs_user

Setting the bug back to resolved, because the test did not fail anymore
Comment 14 Felix Botner univentionstaff 2019-09-23 12:41:54 CEST
Everything OK, just changed/added changelog/release notes.

@Erik, please QA the changelog/release notes changes on (commit b7ec8daff72b96424cb15ffbf97b8f8ed713f23a)
Comment 15 Erik Damrose univentionstaff 2019-09-23 15:57:10 CEST
OK: changelog
I fixed some typos in the release notes
Verified
Comment 16 Erik Damrose univentionstaff 2019-10-29 10:53:51 CET
UCS 4.4-2 has been released.
Comment 17 Florian Best univentionstaff 2021-03-02 21:47:02 CET
*** Bug 40243 has been marked as a duplicate of this bug. ***