Univention Bugzilla – Bug 50236
Remove filter hack from users/user
Last modified: 2019-10-16 14:11:08 CEST
Created attachment 10186 [details] patch (git:fbest/50236-users-user-filter-rewrite-conjunction) users/user.py integrates multiple ldap filters into one univention.admin.filter.expression. e.g.: 2306 » » » if filter.value == '1': 2307 » » » » filter.variable = '&(shadowExpire=1)(krb5KDCFlags:1.2.840.113556.1.4.803:=128)(|(sambaAcctFlags=[UD ])(sambaAcctFlags' 2308 » » » » filter.value = '[ULD ]))' This is not necessary, filter.transform_to_conjunction() can nowerdays be used.
Created attachment 10187 [details] patch (git:fbest/50236-users-user-filter-rewrite-conjunction)
The content of attachment 10186 [details] has been deleted for the following reason: broken
Patch applied, no behavior change. QA: # ucr set directory/manager/cmd/debug/level='99' # pkill -f cli-server # tail -f /var/log/univention/directory-manager-cmd.log | grep 'uldap.search filter=' | grep univentionObjectType=users/user & # udm users/user list --filter 'disabled=all' > /dev/null # udm users/user list --filter 'disabled=1' > /dev/null # udm users/user list --filter 'disabled=0' > /dev/null # udm users/user list --filter 'locked=1' > /dev/null # udm users/user list --filter 'locked=0' > /dev/null → filter should not have changed Fixed in: univention-directory-manager-modules (14.0.14-4) 2182db93360b | Bug #50236: Make univention.admin.filter.expression(escape=False) explicit 96a7ee04a5ec | Bug #50236: fix users/user filter rewrite to not create invalid filter.expression instances univention-directory-manager-modules.yaml 96a7ee04a5ec | Bug #50236: fix users/user filter rewrite to not create invalid filter.expression instances
OK: filter for disabled and locked property is still the same OK: explicit use of esacped=False OK: yaml -> verified
<http://errata.software-univention.de/ucs/4.4/306.html>