Univention Bugzilla – Bug 50573
[O365] wizard traceback when downloading public cert
Last modified: 2020-02-13 09:51:16 CET
Request: office365/o365_public_signing_cert.pem Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/univention/management/console/base.py", line 358, in __error_handling six.reraise(etype, exc, etraceback) File "/usr/lib/python2.7/dist-packages/univention/management/console/base.py", line 261, in execute function.__func__(self, request, *args, **kwargs) File "/usr/lib/pymodules/python2.7/univention/management/console/modules/office365/__init__.py", line 145, in public_signing_cert with open(AzureADConnectionHandler.get_conf_path('SSL_CERT'), 'rb') as fd: TypeError: get_conf_path() takes exactly 3 arguments (2 given)
d1140eb2 Fix issues in wizard with certificate download and saml setup script creation * Fixed function call to get the correct certificate when clicking the download link * write_saml_setup_script() now respects the adconnection alias when creating the saml setup script. The issuer is also calculated correctly, and is derived directly from UCR ucs/server/sso/fqdn instead of umc/saml/idp-server - which is indirectly calculated from ucs/server/sso/fqdn anyway. univention-office365 2.0.2-45A~4.4.0.201911281319
The o365_usertokens script executed by a cronjob does not work - it has to iterate over the initialiazed connections and reset the tokens there.
c272a81b o365_usertokens now iterates over all azure ads the user is part of, and resets the tokens. univention-office365 2.0.2-47A~4.4.0.201911281619
Created attachment 10235 [details] proposed patch Two bugs: If A user is created on the umc without the o365 Template but with a ConnectionAlias a traceback is thrown. -> Problem with the udm hook The listener only deactivates/activates one ConnectionAlias. Otherwise it looks good: Cert download works Saml Powershell Skript is modified Tokens are renewed for all connections Login at multiple Azure ADs works
Thank you for the patch, which i applied. There was a small copy+paste error for the group listener, and i fixed style issues in the hook while committing it. 2f8ea93c Adapt user and group listener with QA feedback, fix hook univention-office365 2.0.2-48A~4.4.0.201911291006
As discussed, the user listener delete_user function has been adapted. I also fixed the subscriptions test and improved the adconnection parsing in print_users_and_groups git a18ae83d; univention-office365 2.0.2-50A~4.4.0.201912021530
What I tested (see comment 4 as well): Delete works -> OK print_users_and_groups -> OK Migration works -> OK jenkins -> https://jenkins.knut.univention.de:8181/job/UCS-4.4/job/UCS-4.4-2/job/product-test-component-office365/36/ -> OK -> verified
Closed: Released with App Version 3.0 for UCS 4.4