Bug 50609 - Make "How do I login?" in login configurable
Make "How do I login?" in login configurable
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-3-errata
Assigned To: Johannes Keiser
Julia Bremer
:
Depends on:
Blocks: 51466 50608 50610
  Show dependency treegraph
 
Reported: 2019-12-06 15:01 CET by Valentin Heidelberger
Modified: 2020-06-11 09:16 CEST (History)
6 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.023
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
Hide "How do I login" in UMC login (781 bytes, patch)
2020-01-07 10:53 CET, Valentin Heidelberger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Valentin Heidelberger univentionstaff 2019-12-06 15:01:21 CET
Below the UMC login box there are 2-3 links, depending on whether it's a SAML login. Among them is "How do I login?" This link should be configurable. One should be able to change persistently at least:

- Whether the link is shown (enable/disable)
- Where link exactly leads to (Linking to any URL should be possible)
Comment 1 Valentin Heidelberger univentionstaff 2020-01-07 10:53:28 CET
Created attachment 10279 [details]
Hide "How do I login" in UMC login

As requested, here is my very simple patch for a customer who needs this (specifically hiding the link).
Comment 2 Johannes Keiser univentionstaff 2020-02-06 14:48:16 CET
fdb2a9db6d Bug #50609: yaml
b1f087407c Bug #50609: Merge branch 'jkeiser/4.4-3/login_links_ucr' into 4.4-3
6c17f53a1a Bug #50609: yaml
6059921d5c Bug #50609: debian changelog
94ad61cbf8 Bug #50609: fix Tooltip eating click event on links
e747018bd6 Bug #50609: login links can be added via ucr

I added the function login/dialog.addLinkFromUcr(name, defaults)

If a link is added with this function then the corresponding ucr variables
umc/login/links/{name}/enabled
umc/login/links/{name}/text
umc/login/links/{name}/text/{locale}
umc/login/links/{name}/href
umc/login/links/{name}/href/{locale}
umc/login/links/{name}/tooltip
umc/login/links/{name}/tooltip/{locale}
umc/login/links/{name}/target

can be used to edit the link (and overwrite possible defaults defined in javascript)

----
The "How do I login?" link is now added via addLinkFromUcr('how_do_i_login') and can therefore be modified via umc/login/links/how_do_i_login/.*
Comment 3 Christian Castens univentionstaff 2020-02-07 16:00:17 CET
We discussed UCR Variable descriptions and decided to change it for readability.
Comment 4 Christian Castens univentionstaff 2020-02-07 16:19:23 CET
Functionality has been tested for all ucr-variables listed below:

umc/login/links/{name}/enabled
umc/login/links/{name}/text
umc/login/links/{name}/text/{locale}
umc/login/links/{name}/href
umc/login/links/{name}/href/{locale}
umc/login/links/{name}/tooltip
umc/login/links/{name}/tooltip/{locale}
umc/login/links/{name}/target

Tested for all three possible names: "forgot_your_password", "login_without_sso" and "how_do_i_login". 


Everything works as intended.
Comment 5 Johannes Keiser univentionstaff 2020-02-10 14:05:20 CET
f0e21e9b93 Bug #50609: yaml
d60280bdb7 Bug #50609: debian changelog
2fd9566972 Bug #50609: change ucr variable description

Successful build
Package: univention-management-console
Version: 11.0.4-55A~4.4.0.202002101402
Comment 6 Julia Bremer univentionstaff 2020-02-10 15:06:22 CET
Functionality of all the Variables tested by ccastens : OK
yaml: OK
variable description: OK

-> Verified
Comment 7 Erik Damrose univentionstaff 2020-02-12 15:40:33 CET
<http://errata.software-univention.de/ucs/4.4/442.html>