Bug 50636 - If the creation of the exam-mode breaks, remnants should be removed and changes revoked
If the creation of the exam-mode breaks, remnants should be removed and chang...
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Exam mode
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v7
Assigned To: Tobias Wenzel
Ole Schwiegert
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-12-13 10:40 CET by Christina Scheinig
Modified: 2020-10-12 16:19 CEST (History)
6 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 5: Blocking further progress on the daily work
User Pain: 0.114
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2019121221000667
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christina Scheinig univentionstaff 2019-12-13 10:40:27 CET
If the creation of the exam-mode breaks or was canceled during its creation, there are still some remnants:

1. The exams users remain unchanged, but these are cleaned up by the exam-and-room-cleanup.

2. The user based on the exam user retains the attribute "sambaUserWorkstations: $".
This is not removed by the cleanup script. This causes the students not to be able to login anymore, till this is fixed.
This can only be removed manually via UDM or with a properly completed class test.
At least the exam-and-room-cleanup should remove this attribute value, too.
Comment 1 Ingo Steuwer univentionstaff 2020-07-10 11:00:43 CEST
We had various improvements in the Exam Mode in the last months, is this bug report still valid?
Comment 2 Christina Scheinig univentionstaff 2020-07-10 15:03:29 CEST
As usual the ticket is closed. Do you expect me to reopen it and ask the customer, if this is still a problem.

What does your automated test say? This should be easy to reproduce.
Comment 3 Ingo Steuwer univentionstaff 2020-07-10 15:11:53 CEST
(In reply to Ingo Steuwer from comment #1)
> We had various improvements in the Exam Mode in the last months, is this bug
> report still valid?

I should have been more precise - I'd like to get feedback from development or Michel here
Comment 4 Michel Smidt 2020-07-24 11:46:38 CEST
(In reply to Ingo Steuwer from comment #3)
> (In reply to Ingo Steuwer from comment #1)
> > We had various improvements in the Exam Mode in the last months, is this bug
> > report still valid?
> 
> I should have been more precise - I'd like to get feedback from development
> or Michel here

We will check that.
Comment 6 Tobias Wenzel univentionstaff 2020-09-22 17:04:35 CEST
I implemented a fix in 

[twenzel/50636_exam_break_up] 754beaad4 Bug #50636: restore orig user data in cleanup script

(of course I meant cleanup :) )
Comment 7 Ole Schwiegert univentionstaff 2020-09-28 08:00:18 CEST
There is a typo in your code
"self.restore_original_usesr(user.dn)"

After fixing that on my local branch, I tested by starting an exam and executing 
"/usr/share/ucs-school-exam/exam-and-room-cleanup --skip-exam-shutdown"

The sambaWorkstations of the original users were cleaned up. Both with previously empty and filled values.

Please fix typo and create a test for the exam-and-room-cleanup script. You do not need to test the entire functionality of the script, but the newly added one of cleaning up original users sambaWorkstations.

After that please merge and build
Comment 8 Tobias Wenzel univentionstaff 2020-09-28 11:59:49 CEST
I corrected the type & wrote a test. The branch was renamed, too. After that I merged & built.

[4.4] c1752489e Bug #50636: yaml version
[4.4] 8b39b793f Bug #50636: Changelogs & yamls
[4.4] 95ab9738e Bug #50636: Merge branch 'twenzel/50636_exam_cleanup' into 4.4
[4.4] 5cb886a1a Bug #50636: add ucs-test
[4.4] b9fecc878 Bug #50636: restore orig user data in cleanup script


Package: ucs-school-umc-exam
Version: 9.0.1-41A~4.4.0.202009281152
Branch: ucs_4.4-0
Scope: ucs-school-4.4


Package: ucs-test-ucsschool
Version: 6.0.141A~4.4.0.202009281155
Branch: ucs_4.4-0
Scope: ucs-school-4.4
Comment 9 Ole Schwiegert univentionstaff 2020-09-29 08:38:19 CEST
Package installs: OK
Changelog&Advisory: OK
Tests: OK
Comment 10 Daniel Tröder univentionstaff 2020-10-12 16:19:03 CEST
UCS@school 4.4 v7 has been released.

https://docs.software-univention.de/changelog-ucsschool-4.4v7-de.html

If this error occurs again, please clone this bug.