Bug 50644 – S4C memory leak in group member cache

Bug 50644 - S4C memory leak in group member cache


Summary:	S4C memory leak in group member cache

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	S4 Connector
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-3-errata
Assigned To:	Arvid Requate
QA Contact:	Florian Best

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-12-16 17:03 CET by Arvid Requate
Modified:	2020-01-15 17:00 CET (History)
CC List:	1 user (show)

See Also:	50643
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Flags:	requate: Patch_Available+

Attachments
fix_s4c_memory_leak_in_group_member_cache.patch (4.83 KB, patch) 2019-12-16 17:03 CET, Arvid Requate	Details \| Diff
patch (git:fbest/50644-memory-leak) (7.12 KB, patch) 2019-12-17 12:41 CET, Florian Best	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arvid Requate

2019-12-16 17:03:57 CET

Created attachment 10273 [details]
fix_s4c_memory_leak_in_group_member_cache.patch

From reading the S4-Connector code I think the s4().group_members_cache_* could be growing indefinitely, see attached patch.

Comment 1 Florian Best

2019-12-17 12:41:28 CET

Created attachment 10274 [details]
patch (git:fbest/50644-memory-leak)

Alternative patch using python's set() which reduces the diff and simplifies the code.

Comment 2 Arvid Requate

2019-12-19 13:25:39 CET

e31e8d76ef | Turn self.group_members_cache_* into a set()
72479b1800 | Fix another self.group_members_cache_ucs type initialization
12d285dfd7 | Advisory

Comment 3 Florian Best

2019-12-20 09:10:55 CET

OK: fix
OK: Code review
OK: jenkins-Tests
OK: YAML

Comment 4 Erik Damrose

2020-01-15 17:00:00 CET

<http://errata.software-univention.de/ucs/4.4/422.html>