Bug 50733 - Diagnostic module for UCR notifier/protocol/version
Diagnostic module for UCR notifier/protocol/version
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - System diagnostic
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-8-errata
Assigned To: Iván.Delgado
Arvid Requate
:
Depends on:
Blocks: 54264
  Show dependency treegraph
 
Reported: 2020-01-21 17:08 CET by Erik Damrose
Modified: 2021-12-22 13:50 CET (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): bitesize
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Damrose univentionstaff 2020-01-21 17:08:31 CET
Add a check that warns if UCR notifier/protocol/version is not 3. Otherwise the domain is affected by bug 48427

Describe that every UCS domain server has to be at least UCS 4.3-3e428 before increasing the minimum protocol version to 3.
Comment 1 Iván.Delgado univentionstaff 2021-12-20 14:37:56 CET
A diagnostic module has been added to check the UCR variable notifier/protocol/version

1ba15062da
03bb557e85
d3c10739db
c6e76f2668
504b5fb0a3
1906206d6f


univention-management-console-module-diagnostic: 5.0.1-53A~4.4.0.202112201428
Comment 2 Arvid Requate univentionstaff 2021-12-20 15:08:23 CET
Please make the file name 61_version.py a bit more specific, like 61_notifier_protocol_version.py

And make the check robust against e.g.

root@master60:~# ucr set notifier/protocol/version='a'
Setting notifier/protocol/version
root@master60:~# /usr/bin/univention-run-diagnostic-checks -t 61_version
Domain Admin Login: Administrator
Password: 

You can find the logging messages of the diagnostic modules at /var/log/univention/management-console-module-diagnostic.log

################################ Start 61_version ###############################
## Check failed: 61_version - Die Notifier-Protokollversion ist geringer als 3 ##
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/univention/management/console/modules/diagnostic/__init__.py", line 280, in execute
    result = execute(umc_module, **kwargs)
  File "/usr/lib/python2.7/dist-packages/univention/management/console/modules/diagnostic/plugins/61_version.py", line 46, in run
    if int(np_version) < 3:
ValueError: invalid literal for int() with base 10: 'a'
################################# End 61_version ################################
Comment 3 Iván.Delgado univentionstaff 2021-12-21 13:18:36 CET
I've applied the suggested changes.

b08cc30666
948bab3c67
cb26127f8d
1ba15062da
03bb557e85
d3c10739db
c6e76f2668
504b5fb0a3
1906206d6f

univention-management-console-module-diagnostic: 5.0.1-54A~4.4.0.202112211309
Comment 4 Iván.Delgado univentionstaff 2021-12-21 15:25:42 CET
I've fixed the German's translations.

c5284159f6
0be3f21d85
b08cc30666
948bab3c67
cb26127f8d
1ba15062da
03bb557e85
d3c10739db
c6e76f2668
504b5fb0a3
1906206d6f

univention-management-console-module-diagnostic: 5.0.1-55A~4.4.0.202112211520
Comment 5 Arvid Requate univentionstaff 2021-12-21 15:33:54 CET
Verified:
* Code review
* Package update
* Functional tests
* Advisory