Bug 51074 - Implement "Subnet directed broadcasts" for WoL
Implement "Subnet directed broadcasts" for WoL
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Computer room administration
unspecified
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v5-errata
Assigned To: Tobias Wenzel
Ole Schwiegert
https://en.wikipedia.org/wiki/Wake-on...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-07 13:06 CEST by Christian Völker
Modified: 2020-06-10 14:37 CEST (History)
3 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?: Yes
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2020040721000377
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Völker univentionstaff 2020-04-07 13:06:19 CEST
Larger customers frequently have multiple networks separated by routers/ firewalls. 
Especially in schools with BYOD it is highly recommended to have the student's devices in a different network than the server!

Our current implementation of "Wake on Lan" sends simple broadcast packets to wake up the clients in a computer room.

Before (See bug #49970) we used the tool wakeonlan where the customer was able to tweak the tool and send "subnet directed broadcasts" instead of default broadcasts.


With the new implementation customer can not send WoL through firewalls and thus would need to put the pupils devices in thee same network as the server.

Customers having the server in a diffenrent network can not use this feature at all! Same applies for customers having the server in a centralized server pool.

We should implement "subnet directed broadcasts" in out tool to allow customers using this feature.
Comment 1 Erik Damrose univentionstaff 2020-04-15 18:22:22 CEST
Did this work in a previous version of UCS@school without further adaptions? If so, this is a regression and therefore a bug report, not a feature request.
Comment 2 Christian Völker univentionstaff 2020-04-15 19:18:35 CEST
Not without further adaptions, no.

As mentioned in bug #49970 customer changed the following line in the perl script "wakeonlan":


# my $DEFAULT_IP      = '255.255.255.255';
my $DEFAULT_IP      = '172.14.30.5';    


And so the packets went through routing borders.

Now we are not using wakeonlan any more and therefor customer's changes have no effect.
Comment 3 Tobias Wenzel univentionstaff 2020-05-26 11:23:55 CEST
I added an ucr-v description for ucsschool/umc/computerroom/wakeonlan/target_nets, which expects a list of broadcast ips. The value is passed to wakeonlan.py::send_wol_packet with the default value ['255.255.255.255'] and sent to each of the addresses. 

A test using tshark was implemented. Since sending packages to multiple ips would require multiple machines, the exception which is raised when using a non-existing address is catched. The tshark output then is searched for hints, that packages were tried to send there. Please also test this on-site.


[twenzel/51074_target_subnets_for_wakeonlan] 585f87055 Bug #51074: Read ucr-v in italc and ucs-test
[twenzel/51074_target_subnets_for_wakeonlan] 153137506 Bug #51074: Add parameter in wakeonlan script and ucr-v description
Comment 4 Tobias Wenzel univentionstaff 2020-05-26 12:14:58 CEST
Added Documentation in 

[twenzel/51074_target_subnets_for_wakeonlan] e7b8de8a7 Bug #51074: Documentation
Comment 5 Tobias Wenzel univentionstaff 2020-05-28 12:19:29 CEST
As discussed I implemented the suggested remarks in

[twenzel/51074_target_subnets_for_wakeonlan] 3ae104e31 Bug #51074: add qa suggestions
Comment 6 Tobias Wenzel univentionstaff 2020-06-03 11:13:48 CEST
First QA response was good, hence merge&build 4.4

[4.4] 4e2d95c86 Bug #51074: ucs-test add missing package
[4.4] 0f1a5970a Bug #51074: Changelog, Yaml & missing word in UCR-V
[4.4] 28e77f55b Bug #51074: add qa suggestions
[4.4] e8a89cb5d Bug #51074: Documentation
[4.4] 6f396210b Bug #51074: Read ucr-v in italc and ucs-test
[4.4] c1e90bee2 Bug #51074: Add parameter in wakeonlan script and ucr-v description

Package: ucs-school-umc-computerroom
Version: 11.0.0-20A~4.4.0.202006031054
Branch: ucs_4.4-0
Scope: ucs-school-4.4
Comment 7 Ole Schwiegert univentionstaff 2020-06-05 06:48:44 CEST
Package installs: OK
Changelog&Advisory: OK
CodeReview: OK
Manual tests on hardware: OK
UCS-test: OK
Comment 8 Ole Schwiegert univentionstaff 2020-06-10 14:37:11 CEST
UCS@school 4.4 v5 has been released (errata update to the release).

https://docs.software-univention.de/changelog-ucsschool-4.4v5-de.html

If this error occurs again, please clone this bug.