Bug 51098 – univention-management-console: make UCR templates python3-compatible

Bug 51098 - univention-management-console: make UCR templates python3-compatible


Summary:	univention-management-console: make UCR templates python3-compatible

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC (Generic)
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-4-errata
Assigned To:	Florian Best
QA Contact:	Jürn Brodersen

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-04-14 10:58 CEST by Florian Best
Modified:	2020-04-22 15:30 CEST (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Florian Best

2020-04-14 10:58:25 CEST

The UCR templates of univention-management-console have to be python3-compatible.

Comment 1 Florian Best

2020-04-14 12:40:12 CEST

univention-management-console.yaml
dbe3cf60b473 | YAML Bug #51098

univention-management-console (11.0.4-59)
d2824180c68e | Bug #51098: make UCR templates compatible to python3

Comment 2 Jürn Brodersen

2020-04-16 15:04:53 CEST

"usr/share/univention-management-console/meta.json" is not python3 compatible

("from univention.lib.misc import custom_username" Needs to be commented out for testing)

'''
File: /usr/share/univention-management-console/meta.json
Traceback (most recent call last):
  File "<stdin>", line 128, in <module>
  File "<stdin>", line 88, in get_ec2_address
  File "<stdin>", line 49, in get_ip_address
struct.error: argument for 's' must be a bytes object

'''
"struct.pack('256s', ifname[:15])" -> "struct.pack('256s', ifname[:15].encode('utf8'))" ?


and one iteritems :)

'''
File: /usr/share/univention-management-console/meta.json
Traceback (most recent call last):
  File "<stdin>", line 135, in <module>
  File "<stdin>", line 125, in get_login_links
AttributeError: 'ConfigRegistry' object has no attribute 'iteritems'
'''

Comment 3 Jürn Brodersen

2020-04-16 15:05:07 CEST

Otherwise it looks good

Comment 4 Florian Best

2020-04-16 15:18:13 CEST

univention-management-console (11.0.4-60)
dfea9a6d6dc8 | Bug #51098: fix python3 compatibility in meta.json

Comment 5 Jürn Brodersen

2020-04-16 18:51:35 CEST

- Changes -> OK
- yaml -> OK
- jenkins -> OK

-> Verified

Comment 6 Erik Damrose

2020-04-22 15:30:43 CEST

<http://errata.software-univention.de/ucs/4.4/548.html>