Bug 51124 - add UCRV for Postfix settings delay_warning_time, maximal_queue_lifetime and
add UCRV for Postfix settings delay_warning_time, maximal_queue_lifetime and
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Mail
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-6-errata
Assigned To: Toni Röhmeyer
Tobias Wenzel
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-20 16:07 CEST by Dirk Ahrnke
Modified: 2020-09-30 15:37 CEST (History)
4 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Workaround is available
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Ahrnke univentionstaff 2020-04-20 16:07:33 CEST
The setting http://www.postfix.org/postconf.5.html#delay_warning_time defaults to 0 by default. 
As a result no warnings for temporarily undeliverable messages are sent until http://www.postfix.org/postconf.5.html#maximal_queue_lifetime (or http://www.postfix.org/postconf.5.html#bounce_queue_lifetime) is reached. Those default to 5 days.

Even if it is possible to define all these settings in main.cf.local it would make sense to make them controllable by UCR and - for larger installations - by a UCR-policy.
Comment 4 Toni Röhmeyer univentionstaff 2020-09-09 14:17:18 CEST
I added the UCRVs...
mail/postfix/maximal_queue_lifetime
mail/postfix/bounce_queue_lifetime
mail/postfix/delay_warning_time


in commit

commit fef58444c3de07f49cd9b0126d7f0008924c6e73
Bug #51124: added postfix UCRVs

on branch troehmey/bug51124_add_postfix_ucrv
Comment 5 Tobias Wenzel univentionstaff 2020-09-17 14:01:46 CEST
QA: looks Ok, but I have some remarks:

mail/postfix/maximal_queue_lifetime
-> UCRV text is ok, but the english translation is slightly different than the german text. 

mail/postfix/delay_warning_time
-> Bei gescheiterter Maileinlieferung, -> comma is not needed.

10_general
-> You can simplefy your code a little bit:

delay = configRegistry.get('mail/postfix/delay_warning_time', '')
if delay:
    print('delay_warning_time = %s' % delay)

I would also add the default like in mail/postfix/postscreen/greet/ttl and add the default value to be more explicit (e.g.):

delay = configRegistry.get('mail/postfix/delay_warning_time', '0h')
if delay:
    print('delay_warning_time = %s' % delay)
Comment 6 Toni Röhmeyer univentionstaff 2020-09-18 17:39:58 CEST
Applied suggested fixes with commit

commit db9585f31d71a39e7e83975a04914eaa27a206c0
Bug #51124: improved description texts and code clarity
Comment 7 Tobias Wenzel univentionstaff 2020-09-21 16:19:38 CEST
REOPEN

Please add the Type & Categories in the UCR-V file. Otherwise ucr info mail/postfix/delay_warning_time can't be displayed. 

Other than that the file is updated, when the ucr-vs change.
Comment 8 Toni Röhmeyer univentionstaff 2020-09-22 12:43:03 CEST
Sorry, totally overlooked that...

Fixed with...

commit c0c8fb27e5cf15fa0b8bd56c625f495436e5ed87
Bug #51124: add type and category to UCRVs
Comment 9 Tobias Wenzel univentionstaff 2020-09-25 09:35:03 CEST
Thanks for the quick response!
Now the info text is displayed as expected.

REOPEN for merge to 4.4-6 & build.
Comment 10 Toni Röhmeyer univentionstaff 2020-09-25 11:01:58 CEST
Merged with commits

eb8254e2e4 Bug #51124: added yaml
14366ea37f Bug #51124: added changelog entry
c3cbfbfa95 Bug #51124: Merge branch 'troehmey/bug51124_add_postfix_ucrv' into 4.4-6


successful build:

Package: univention-mail-postfix
Version: 13.0.2-2A~4.4.0.202009251042
Branch: ucs_4.4-0
Scope: errata4.4-6
Comment 11 Tobias Wenzel univentionstaff 2020-09-25 14:53:52 CEST
QA -> All OK -> VERIFY

Changelog -> OK
YAML -> OK
Merge without conflicts -> OK