First Last Prev Next    This bug is not in your last search results.
Bug 51131 - univention-samba4 and univention-samba: make UCR templates python3-compatible
univention-samba4 and univention-samba: make UCR templates python3-compatible
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Samba4
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-4-errata
Assigned To: Florian Best
Arvid Requate
:
Depends on:
Blocks: 51212
  Show dependency tree / graph
 
Reported: 2020-04-21 13:33 CEST by Florian Best
Modified: 2020-05-04 13:11 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2020-04-21 13:33:37 CEST 
The UCR templates of univention-samba4 have to be python3-compatible.
Comment 1 Florian Best univentionstaff 2020-04-21 14:17:50 CEST 
univention-samba4.yaml
9be6c5ea2f2e | YAML Bug #51131

univention-samba4 (8.0.0-30)
c9c4158805af | Bug #51131: make UCR templates compatible to python3
d6591ca45810 | Bug #51131: pep8; make UCR templates compatible to python3
Comment 2 Florian Best univentionstaff 2020-04-21 14:56:08 CEST 
The package univention-samba should also be migrated:

univention-samba.yaml
c34de7c9ca41 | YAML Bug #51131

univention-samba (13.0.0-8)
cc95fda65251 | Bug #51131: make UCR templates compatible to python3
Comment 3 Arvid Requate univentionstaff 2020-04-22 15:17:43 CEST 
The space got lost in /etc/logrotate.d/winbind (univention-samba):

/var/log/samba/log.winbindd/var/log/samba/log.winbindd-idmap/var/log/samba/log.winbindd-dc-connect/var/log/samba/log.wb-BUILTIN/var/log/samba/log.wb-AR41I1/var/log/samba/log.wb-MEMBER13{

More generally: I'm not sure if this sys.stdout.write is useful in templates, I'd rather build up the contactenated string and then print() it. In some parts the original trailing comma ('print "foo",') was only there before the closing '@!@' to suppress an extra empty line. That's just cosmetics. But I don't care.
Comment 4 Florian Best univentionstaff 2020-04-22 16:02:58 CEST 
Fixed in:

univention-samba (13.0.0-9)
228bca42bb10 | Bug #51131: fix print statements
6c0e5e913ae7 | Bug #51131: fix print statements

univention-samba4 (8.0.0-31)
301c8a44c118 | Bug #51131: fix print statements
Comment 5 Arvid Requate univentionstaff 2020-04-22 16:30:28 CEST 
Verified:
* Code review
* Commited templates are unchanged
* Advisories
First Last Prev Next    This bug is not in your last search results.