Bug 51169 - Do not send non-students to exam-master
Do not send non-students to exam-master
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: UMC - Exam mode
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v5-errata
Assigned To: Ole Schwiegert
Tobias Wenzel
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-24 13:03 CEST by Ole Schwiegert
Modified: 2020-07-30 15:07 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ole Schwiegert univentionstaff 2020-04-24 13:03:53 CEST
While creating/starting an exam, the exam module sends users to the exam-master module to create exam users for them. At the moment all users of participating groups that are not already exam users are sent, which leads to log messages like this on the exam-master module:

06.04.20 11:35:32.957  MODULE      ( PROCESS ) : UDM object uid=demo_teacher,cn=lehrer,cn=users,ou=DEMOSCHOOL,dc=realm1,dc=intranet is not Student, but actually Teacher
06.04.20 11:35:32.958  MODULE      ( PROCESS ) : Student u'uid=demo_teacher,cn=lehrer,cn=users,ou=DEMOSCHOOL,dc=realm1,dc=intranet' not found.

and on the exam module:

06.04.20 11:35:32.675  MODULE      ( PROCESS ) : Vorbereitung der Klassenarbeitskonten - Student, Demo (demo_student)
06.04.20 11:35:32.854  MODULE      ( PROCESS ) : Exam user has been created: u'uid=exam-demo_student,cn=examusers,ou=DEMOSCHOOL,dc=realm1,dc=intranet'
06.04.20 11:35:32.854  MODULE      ( PROCESS ) : Requesting exam user to be created: u'uid=demo_teacher,cn=lehrer,cn=users,ou=DEMOSCHOOL,dc=realm1,dc=intranet'
06.04.20 11:35:32.854  MODULE      ( PROCESS ) : Vorbereitung der Klassenarbeitskonten - Teacher, Demo (demo_teacher)
06.04.20 11:35:32.963  MODULE      ( WARN    ) : Could not create exam user account for u'uid=demo_teacher,cn=lehrer,cn=users,ou=DEMOSCHOOL,dc=realm1,dc=intranet': 400 on dc0.realm1.intranet (command/schoolexam-master/create-exam-user): {"status": 400, "message": "Student u'uid=demo_teacher,cn=lehrer,cn=users,ou=DEMOSCHOOL,dc=realm1,dc=intranet' not found.", "traceback": null, "location": "https://dc0.realm1.intranet/univention/command"}  


This is unnecessary and might lead to further delay. Only students should be sent to the exam-master module in the first place.
Comment 1 Ole Schwiegert univentionstaff 2020-04-24 13:08:49 CEST
Fix is implemented in oschwieg/4.4/51166

To check just make sure that you have a class including a teacher/staff/admin account and write an exam with this class (demo_teacher is not part of the demo_class by default). Only the students should be send to the schoolexam-master module (the aforementioned log entries will be missing).

Please REOPEN for merge and build
Comment 2 Tobias Wenzel univentionstaff 2020-04-24 15:46:05 CEST
QA -> all ok => please merge&build

[oschwieg/4.4/51166] 253deda3a Bug #51169: Only send students for exam account creation to the schoolexam-master module

Code -> looks good.
Functionality -> works as expected.

Before the fix I got the log msg: 

schoolexam-master/create-exam-user): {"status": 400, "message": "Student u'uid=demo_teacher,cn=lehrer,cn=users,ou=DEMOSCHOOL,dc=wenzel-univention,dc=intranet' not found.", "traceback": null, "location": "https://ucs-3303.wenzel-univention.intranet/univention/command"}   


After fix: No log entries.
Comment 3 Ole Schwiegert univentionstaff 2020-04-24 17:47:42 CEST
Merge&Build:

Package: ucs-school-umc-exam
Version: 9.0.1-38A~4.4.0.202004241746
Branch: ucs_4.4-0
Scope: ucs-school-4.4
Comment 4 Tobias Wenzel univentionstaff 2020-04-27 09:10:38 CEST
changelog -> ok
yaml -> ok

[4.4] 9c521be5c Bug #51169: Add advisory
[4.4] bccef3167 Bug #51169: Add changelog entry
[4.4] 186d2418b Bug #51169: Only send students for exam account creation to the schoolexam-master module
Comment 5 Tobias Wenzel univentionstaff 2020-07-30 15:07:41 CEST
UCS@school X.Y vZ has been released (errata update to the release).

http://docs.software-univention.de/changelog-ucsschool-4.4v5-de.html#changelog:ucsschool:2020-04-27

If this error occurs again, please clone this bug.