Bug 51334 - services/univention-admin-diary: migrate UMC module to python3
services/univention-admin-diary: migrate UMC module to python3
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Florian Best
Sebastian Lobinger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-05-19 14:32 CEST by Florian Best
Modified: 2021-05-25 15:58 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2020-05-19 14:32:48 CEST
The UMC module of services/univention-admin-diary has to be python3-compatible.
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2020-09-29 16:49:03 CEST
The source package contains 3 parts:
- a listener module: ./listener/univention-admin-diary-backend.py
- the python library: /python/admindiary/*
- the UMC module: ./umc/python/*
plus some helper scripts.

Please migrate the python library and the listener module so that they are py2 and py3 compatible. For the UMC module py3 is sufficient.
Comment 2 Sönke Schwardt-Krummrich univentionstaff 2020-09-29 16:53:17 CEST
Within test/ucs-test/tests/87_admindiary/* there are currently 2 ucs-test scripts for the admin diary. If possible, add some new tests.
Comment 3 Sönke Schwardt-Krummrich univentionstaff 2020-09-29 21:20:01 CEST
(In reply to Sönke Schwardt-Krummrich from comment #2)
> Within test/ucs-test/tests/87_admindiary/* there are currently 2 ucs-test
> scripts for the admin diary. If possible, add some new tests.

If I'm right, the first test is not yet migrated to python3.
The second one is a work in progress/unfinished one. 
Please try to complete the test.
Comment 4 Sebastian Lobinger univentionstaff 2020-09-30 09:42:00 CEST
Just for clarification, we make a complete shift to python 3 so python 2.7 will no longer be supported? If both versions should be supported we might need tests for both versions.
Comment 5 Florian Best univentionstaff 2020-09-30 09:57:49 CEST
(In reply to Sebastian Lobinger from comment #4)
> Just for clarification, we make a complete shift to python 3 so python 2.7
> will no longer be supported? If both versions should be supported we might
> need tests for both versions.
No, we have to support Python 2.7 and Python 3.7 in UCS 5.
Just the UMC module will only run with one version (=3), which can drop Python 2 support.
Comment 6 Florian Best univentionstaff 2021-03-02 16:45:37 CET
The Admin Diary inclusive UMC module has been migrated to Python 3:

univention-admin-diary (2.0.1-0)
42f6531a9fbe | Bug #51334: add python 3 compatibility for listener
c9d9c1a93504 | fixup! Bug #51334: add python 3 compatibility
7bc3304bc86d | fixup! Bug #51334: add python 3 compatibility
16f6a892c35a | Bug #51334: add python 3 compatibility
ba60f4081308 | Bug #51334 admin diary: add python3 compatibility
7bff1fda5532 | Bug #51334 admin diary: add python 3 dependencies

ucs-test (10.0.3-8)
7266b00faaed | fixup! Bug #51334: add 87_admindiary/02_write_event.py
4b5704cf7f58 | Bug #51334: add new test for 87_admindiary
55bddd287c5d | fixup! Bug #51334: add 87_admindiary/02_write_event.py
34ad282afce6 | Bug #51334: add 87_admindiary/02_write_event.py
Comment 7 Florian Best univentionstaff 2021-05-25 15:58:29 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".