Bug 51412 - libpam-krb5: merge patches to UCS 5
libpam-krb5: merge patches to UCS 5
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Florian Best
Philipp Hahn
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-06-02 17:25 CEST by Florian Best
Modified: 2021-05-25 16:01 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2020-06-02 17:25:43 CEST
The patches of libpam-krb5 have to be cherry-picked and rebased to UCS 5.0.
Comment 1 Florian Best univentionstaff 2020-06-03 10:59:51 CEST
In Bug #49740 we invented an own patch. I changed to the meanwhile published upstream patch from https://github.com/rra/pam-krb5/issues/13.

r18949 | Bug #51412: fix fuzzy
r18948 | Bug #51412: use patch from upstream
r18935 | Bug #51412: cherry-pick patches to UCS 5.0

Package: libpam-krb5
Version: 4.8-2+deb10u1A~5.0.0.202006021949
Comment 2 Philipp Hahn univentionstaff 2020-06-12 12:54:11 CEST
OK: libpam-krb5/4.4-0-0-ucs/4.7-4+deb9u1-errata4.4-4/001-fix-detection-of-expired-password.quilt libpam-krb5/5.0-0-0-ucs/4.8-2+deb10u1/001-fix-detection-of-expired-password.quilt
OK: vimdiff libpam-krb5/4.4-0-0-ucs/4.7-4+deb9u1-errata4.4-4/002-bug49740-restrict-password-length.quilt libpam-krb5/5.0-0-0-ucs/4.8-2+deb10u1/002-bug49740-restrict-password-length.quilt
 Switches to upstream patch, which uses
  #define PAM_MAX_RESP_SIZE 512
 instead or our previous 1024. That is okay.
OK: =# SELECT * FROM binpkg WHERE major=5 AND site='apt' AND srcpkg='libpam-krb5';
        binpkg         |              binver               | arch  |   srcpkg    |              srcver               | major | minor | patch | scope | site | maintained |    id    
-----------------------+-----------------------------------+-------+-------------+-----------------------------------+-------+-------+-------+-------+------+------------+----------
 libpam-heimdal-dbgsym | 4.8-2+deb10u1A~5.0.0.202006081826 | amd64 | libpam-krb5 | 4.8-2+deb10u1A~5.0.0.202006081826 |     5 |     0 |     0 |       | apt  |            | 17583033
 libpam-heimdal        | 4.8-2+deb10u1A~5.0.0.202006081826 | amd64 | libpam-krb5 | 4.8-2+deb10u1A~5.0.0.202006081826 |     5 |     0 |     0 |       | apt  |            | 17583034
 libpam-krb5-dbgsym    | 4.8-2+deb10u1A~5.0.0.202006081826 | amd64 | libpam-krb5 | 4.8-2+deb10u1A~5.0.0.202006081826 |     5 |     0 |     0 |       | apt  |            | 17583035
 libpam-krb5           | 4.8-2+deb10u1A~5.0.0.202006081826 | amd64 | libpam-krb5 | 4.8-2+deb10u1A~5.0.0.202006081826 |     5 |     0 |     0 |       | apt  |            | 17583036
(4 Zeilen)
OK: python -m univention.repong.dchdiff -l 1 amd64/libpam-krb5_4.8-2+deb10u1A~5.0.0.202006081826_amd64.deb
Comment 3 Florian Best univentionstaff 2020-06-12 12:59:09 CEST
Hm. I think we have to reopen this:
libpam-krb5 has the build-dependency on heimdal.
heimdal has a rewuired patch for libpam-krb5.

heimdal was build on:      7.5.0+dfsg-3A~5.0.0.202006051751 (05.06.2020)
libpam-krb5 was build on: 4.8-2+deb10u1A~5.0.0.202006021949 (02.06.2020)
Comment 4 Florian Best univentionstaff 2020-06-12 13:03:17 CEST
Re-Build:

Package: libpam-krb5
Version: 4.8-2+deb10u1A~5.0.0.202006121259
Comment 5 Philipp Hahn univentionstaff 2020-06-12 15:45:56 CEST
(In reply to Florian Best from comment #3)
> Hm. I think we have to reopen this:
...
> heimdal was build on:      7.5.0+dfsg-3A~5.0.0.202006051751 (05.06.2020)
> libpam-krb5 was build on: 4.8-2+deb10u1A~5.0.0.202006021949 (02.06.2020)

Why?

dpkg -I amd64/libpam-heimdal_4.8-2+deb10u1A~5.0.0.202006121259_amd64.deb 
> Depends: krb5-config, libpam-runtime, libpam0g (>= 0.99.7.1), libc6 (>= 2.26), libkrb5-26-heimdal (>= 1.7~git20161112)

There is no exact dependency, so re-building should not be needed.
(Except when a header-file of heimdal is changed which is used during build of libpam-krb5).
Comment 6 Florian Best univentionstaff 2020-06-12 16:25:25 CEST
(In reply to Philipp Hahn from comment #5)
> (In reply to Florian Best from comment #3)
> > Hm. I think we have to reopen this:
> ...
> > heimdal was build on:      7.5.0+dfsg-3A~5.0.0.202006051751 (05.06.2020)
> > libpam-krb5 was build on: 4.8-2+deb10u1A~5.0.0.202006021949 (02.06.2020)
> 
> Why?
> 
> dpkg -I amd64/libpam-heimdal_4.8-2+deb10u1A~5.0.0.202006121259_amd64.deb 
> > Depends: krb5-config, libpam-runtime, libpam0g (>= 0.99.7.1), libc6 (>= 2.26), libkrb5-26-heimdal (>= 1.7~git20161112)
> 
> There is no exact dependency, so re-building should not be needed.
> (Except when a header-file of heimdal is changed which is used during build
> of libpam-krb5).

I assumed this was the case due to:
4.2-0-0-ucs/1.6~rc2+dfsg-9+deb8u1-errata4.2-3/0200_krb5_get_init_creds_opt_set_change_password_prompt.quilt

But it seems that patch was already part of upstream.
Comment 7 Philipp Hahn univentionstaff 2020-06-12 17:52:45 CEST
OK: # SELECT * FROM binpkg WHERE major=5 AND site='apt' AND srcpkg='libpam-krb5';
        binpkg         |              binver               | arch  |   srcpkg    |              srcver               | major | minor | patch | scope | site | maintained |    id    
-----------------------+-----------------------------------+-------+-------------+-----------------------------------+-------+-------+-------+-------+------+------------+----------
 libpam-heimdal-dbgsym | 4.8-2+deb10u1A~5.0.0.202006121259 | amd64 | libpam-krb5 | 4.8-2+deb10u1A~5.0.0.202006121259 |     5 |     0 |     0 |       | apt  |            | 17755558
 libpam-heimdal        | 4.8-2+deb10u1A~5.0.0.202006121259 | amd64 | libpam-krb5 | 4.8-2+deb10u1A~5.0.0.202006121259 |     5 |     0 |     0 |       | apt  |            | 17755559
 libpam-krb5-dbgsym    | 4.8-2+deb10u1A~5.0.0.202006121259 | amd64 | libpam-krb5 | 4.8-2+deb10u1A~5.0.0.202006121259 |     5 |     0 |     0 |       | apt  |            | 17755560
 libpam-krb5           | 4.8-2+deb10u1A~5.0.0.202006121259 | amd64 | libpam-krb5 | 4.8-2+deb10u1A~5.0.0.202006121259 |     5 |     0 |     0 |       | apt  |            | 17755561
(4 Zeilen)
OK: python -m univention.repong.dchdiff -l 1 amd64/libpam-heimdal_4.8-2+deb10u1A~5.0.0.202006121259_amd64.deb
Comment 8 Florian Best univentionstaff 2021-05-25 16:01:48 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".