Bug 51482 - Remove univention-printquota in UCS 5.0
Remove univention-printquota in UCS 5.0
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Printserver - pykota
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Philipp Hahn
Florian Best
:
: 48359 48557 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-06-12 15:22 CEST by Florian Best
Modified: 2021-05-25 16:01 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2020-06-12 15:22:59 CEST
The package univention-printquota will be removed in UCS 5.0.

We should purge it in the preup.sh (or warn if it's installed and block the update).
Comment 1 Florian Best univentionstaff 2020-06-12 15:23:10 CEST
*** Bug 48557 has been marked as a duplicate of this bug. ***
Comment 2 Florian Best univentionstaff 2020-06-12 15:23:16 CEST
*** Bug 48359 has been marked as a duplicate of this bug. ***
Comment 3 Philipp Hahn univentionstaff 2020-09-21 11:17:22 CEST
Bug #51482: remove univention-printquota

More PyKota related code must be removed from:
- services/univention-printserver/
- doc/extended-docs/printers-4.4.xml

Bug #51482 print: Remove PyKota support
Comment 4 Florian Best univentionstaff 2020-09-22 09:33:41 CEST
Is this complete?:

037a5739dd24 | Bug #51482: remove univention-printquota

univention-printserver (13.0.1-1)
69a9695f0e2a | Bug #51482 print: Remove PyKota support

ucs-test (10.0.1-1)
69a9695f0e2a | Bug #51482 print: Remove PyKota support
Comment 5 Philipp Hahn univentionstaff 2021-03-18 17:13:13 CET
(In reply to Florian Best from comment #4)
> Is this complete?:

Yes.
Comment 6 Florian Best univentionstaff 2021-03-18 17:17:52 CET
FYI: the unjoinscript in 4.4 doesn't remove /etc/pykota.secret.
Comment 7 Florian Best univentionstaff 2021-03-24 20:29:31 CET
a Changelog entry is missing.
Comment 8 Philipp Hahn univentionstaff 2021-03-26 06:52:56 CET
(In reply to Florian Best from comment #7)
> a Changelog entry is missing.

release-notes-5.0-0-en.xml:199-207

[5.0-0] 808326c1f2 doc[[Pytkota]: Changelog
 doc/changelog/changelog-5.0-0.xml | 3 +++
 1 file changed, 3 insertions(+)
Comment 9 Florian Best univentionstaff 2021-04-14 16:37:47 CEST
The change makes the LDAP attribute 'univentionPrinterQuotaSupport' obsolete.
RFC:
* should we remove the attribute from shares/printer and shares/printergroup (or change the description to mark it as obsolete - for compatibility with UCS 4.4 mixed environments)?
* should we mark the attribute obsolete in management/univention-ldap/schema/printer.schema ?
* should we remove /etc/pykota.secret in preup.sh or in the 4.4 unjoin script? it contains the machine secret forever.

I fixed:
bc5dfe74ad fixup! Bug #51482 print: Remove PyKota support

* syntax error in javascript file
* typo in text
* updated translations / fuzzies

OK: printer UMC module
OK: removal of univention-printquota
OK: changelog entry
Comment 10 Philipp Hahn univentionstaff 2021-04-22 23:57:04 CEST
(In reply to Florian Best from comment #9)
> The change makes the LDAP attribute 'univentionPrinterQuotaSupport' obsolete.
> RFC:
> * should we remove the attribute from shares/printer and shares/printergroup (or change the description to mark it as obsolete - for compatibility with UCS 4.4 mixed environments)?

As PyKota is no longer maintained and no longer supported with UCS-5 lets remove it completely.

> * should we mark the attribute obsolete in management/univention-ldap/schema/printer.schema ?

Done.

> * should we remove /etc/pykota.secret in preup.sh or in the 4.4 unjoin script? it contains the machine secret forever.

We could - code for that is already in [phahn/removal500](https://git.knut.univention.de/univention/ucs/-/merge_requests/new?merge_request%5Bsource_branch%5D=phahn%2Fremoval500), but this requires a new bug for errata4.4-8.
As those credentials only give you access to the "pykota PostrgreSQL database" I consider this only a minor issue not worth fixing now.


[5.0-0] c2ffea664b Bug #51482: Remove PyKota print quota support
 .../modules/univention/admin/handlers/policies/fr.po            |  57 +-------------
 .../modules/univention/management/console/handlers/cups/fr.po   | 112 +---------------------------
 .../services/univention-printserver/umc/python/printers/fr.po   |  17 +----
 base/univention-updater/debian/changelog                        |   6 ++
 base/univention-updater/script/check.sh                         |   3 +-
 doc/manual/print-services-de.xml                                |  88 +---------------------
 doc/manual/print-services-en.xml                                |  90 +---------------------
 doc/scenarios/mittelstand-de.xml                                |   8 --
 doc/scenarios/mittelstand-en.xml                                |   8 --
 .../univention-directory-manager-modules/debian/changelog       |   6 ++
 ...
 26 files changed, 49 insertions(+), 755 deletions(-)

Package: univention-updater
Version: 15.0.3-42A~5.0.0.202104222232

Package: ucs-test
Version: 10.0.5-4A~5.0.0.202104222325

Package: univention-printserver
Version: 13.0.2-7A~5.0.0.202104222328

Package: univention-ldap
Version: 16.0.7-2A~5.0.0.202104222330

Package: univention-directory-manager-modules
Version: 15.0.8-2A~5.0.0.202104222332
Comment 11 Florian Best univentionstaff 2021-04-23 16:11:50 CEST
OK: removed from documentation
OK: schema deprecation
OK: removal from UDM
OK: removal from listener

I removed the icon belonging to the UDM module:
65ff464310 Bug #51482: remove obsolete icon
Comment 12 Florian Best univentionstaff 2021-05-25 16:01:08 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".