Bug 51620 - Invalid appcenter-test.software-univention.de/4.3/owncloud_20200417143931.settings
Invalid appcenter-test.software-univention.de/4.3/owncloud_20200417143931.set...
Status: NEW
Product: UCS
Classification: Unclassified
Component: App Center - Self Service
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-0-errata
Assigned To: Erik Damrose
App Center maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-07-06 14:08 CEST by Philipp Hahn
Modified: 2021-04-14 12:02 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
hahn: Patch_Available+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2020-07-06 14:08:38 CEST
During a test upgrade to UCS-5 the following error is shown:

> Filling the App Center file cache from our local archive /usr/share/univention-appcenter/archives/appcenter-test.software-univention.de/4.3/all.tar.gz!
> Downloading "https://appcenter-test.software-univention.de/meta-inf/4.3/index.json.gz"...
> Downloading "http://appcenter-test.software-univention.de/meta-inf/4.3/all.tar.zsync"...
...
> Could not parse /var/cache/univention-appcenter/appcenter-test.software-univention.de/4.3/owncloud_20200417143931.settings
> File contains parsing errors: /var/cache/univention-appcenter/appcenter-test.software-univention.de/4.3/owncloud_20200417143931.settings
>         [line 143]: ' Description = This setting defines the policy for when files and folders in the trash bin will be permanently deleted.\n'
>         [line 144]: ' Description[de] = Diese Einstellung definiert die Richtlinie daf\xc3\xbcr, wann Dateien und Ordner im Papierkorb dauerhaft gel\xc3\xb6scht werden.\n'
>         [line 145]: ' Type = String\n'
>         [line 146]: ' InitialValue = 7, 14\n'
>         [line 147]: ' Required = false\n'
>         [line 148]: ' Show = Settings\n'
                       ^
> File: /usr/share/univention-management-console/modules/apps.xml

The lines of that section are indented by one space instead of starting in the first column directly.

The ConfigParser of Python3 is more strict and forbids this. This might also happen in UCS-4.4 were certain parts of the code already use Python3 or the backport of its ConfigParser.

The AppCenter-Portal (or whatever) should validate the data and use the strict mode for that.
Comment 1 Erik Damrose univentionstaff 2020-07-06 14:20:40 CEST
This app version is not released yet, and errors may occur in unreleased apps. I am changing the component to app center self-service, because that component should verify uploaded files to the test app center.