Bug 51688 – remove second docker pull during app update (compose)

Bug 51688 - remove second docker pull during app update (compose)


Summary:	remove second docker pull during app update (compose)

Status:	NEW

Product:	UCS
Classification:	Unclassified
Component:	App Center
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	App Center maintainers
QA Contact:	App Center maintainers

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2020-07-20 14:11 CEST by Felix Botner
Modified:	2020-12-04 11:16 CET (History)
CC List:	1 user (show)

See Also:	52456
What kind of report is it?:	Bug Report
What type of bug is this?:	4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?:	2: Will only affect a few installed domains
How will those affected feel about the bug?:	5: Blocking further progress on the daily work
User Pain:	0.229
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:	2020071421000312
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Felix Botner

2020-07-20 14:11:31 CEST

During the update of docker compose apps (not checked for docker apps) we call pull twice:

Calling docker-compose -p wekan pull
Calling docker-compose -p wekan start
Calling docker-compose -p wekan start
Calling docker-compose -p wekan stop
Calling docker-compose -p wekan stop
Calling docker-compose -p wekan down --remove-orphans
Running command: docker-compose -p wekan pull
Running command: docker-compose -p wekan up -d --no-build --no-recreate
Calling docker-compose -p wekan start
Calling docker-compose -p wekan start


If the second pull call fails, we end up with an undefined app state, app is no longer usable, and updates also do not work

I think we added the first pull, so that we are sure we have downloaded the new image before change the current app. But seems that we forgot to remove the second pull call.

That is what this bug is about, remove the unnecessary second pull call.